-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add rewrite-table-path in spark procedure #12115
base: main
Are you sure you want to change the base?
Conversation
``` | ||
|
||
Lastly, [register_table](#register_table) procedure can be used to register copied table in the target location with catalog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we mentioned the validation to make sure table is usable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some offline discussion with @RussellSpitzer, I think referential integrity validation before table registration is great but it's hard to tell customer to do X without information on how to do X.
My plan is omit this for now in documentation, expand the logic in register_table procedure to allow for optional referential integrity check in another PR and come back to update this.
What do you think @flyrain ?
thank you @flyrain @RussellSpitzer for the promptly review, updated per your suggestion! |
Co-authored-by: Russell Spitzer <[email protected]>
Co-authored-by: Russell Spitzer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks better, some more nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor comment. Thanks for doing this!
Co-authored-by: Yufei Gu <[email protected]>
Documentation for #11931 #11555
I took wording and docs with original author of @flyrain and @szehon-ho
Also @manuzhang is interested in this and wondering if @amogh-jahagirdar is ready to take this as part of 1.8