Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add rewrite-table-path in spark procedure #12115

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

dramaticlly
Copy link
Contributor

@dramaticlly dramaticlly commented Jan 27, 2025

Documentation for #11931 #11555

I took wording and docs with original author of @flyrain and @szehon-ho
Also @manuzhang is interested in this and wondering if @amogh-jahagirdar is ready to take this as part of 1.8

@github-actions github-actions bot added the docs label Jan 27, 2025
```

Lastly, [register_table](#register_table) procedure can be used to register copied table in the target location with catalog.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we mentioned the validation to make sure table is usable?

Copy link
Contributor Author

@dramaticlly dramaticlly Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some offline discussion with @RussellSpitzer, I think referential integrity validation before table registration is great but it's hard to tell customer to do X without information on how to do X.

My plan is omit this for now in documentation, expand the logic in register_table procedure to allow for optional referential integrity check in another PR and come back to update this.

What do you think @flyrain ?

@dramaticlly
Copy link
Contributor Author

thank you @flyrain @RussellSpitzer for the promptly review, updated per your suggestion!

Co-authored-by: Russell Spitzer <[email protected]>
@dramaticlly
Copy link
Contributor Author

thank you Russell for the detailed review! This is getting closer and I did a local check to ensure the info and warning section rendered as expected like in following screenshot. image

docs/docs/spark-procedures.md Outdated Show resolved Hide resolved
docs/docs/spark-procedures.md Outdated Show resolved Hide resolved
docs/docs/spark-procedures.md Show resolved Hide resolved
docs/docs/spark-procedures.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@szehon-ho szehon-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks better, some more nits

docs/docs/spark-procedures.md Outdated Show resolved Hide resolved
docs/docs/spark-procedures.md Outdated Show resolved Hide resolved
docs/docs/spark-procedures.md Outdated Show resolved Hide resolved
docs/docs/spark-procedures.md Outdated Show resolved Hide resolved
docs/docs/spark-procedures.md Outdated Show resolved Hide resolved
docs/docs/spark-procedures.md Outdated Show resolved Hide resolved
docs/docs/spark-procedures.md Outdated Show resolved Hide resolved
docs/docs/spark-procedures.md Show resolved Hide resolved
Copy link
Contributor

@flyrain flyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment. Thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants