Remove deprecated WRITE_METADATA_LOCATION and WRITE_FOLDER_STORAGE_LOCATION
#12174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_LOCATION` Has been deprecated since 0.12.0
singhpk234
reviewed
Feb 4, 2025
dramaticlly
reviewed
Feb 6, 2025
Comment on lines
-140
to
+137
| dataLocation = properties.get(TableProperties.OBJECT_STORE_PATH); | ||
| if (dataLocation == null) { | ||
| dataLocation = properties.get(TableProperties.WRITE_FOLDER_STORAGE_LOCATION); | ||
| if (dataLocation == null) { | ||
| dataLocation = String.format("%s/data", tableLocation); | ||
| } | ||
| } | ||
| dataLocation = String.format("%s/data", tableLocation); |
There was a problem hiding this comment.
I enjoy remove deprecated method or config but it's always a bit risky. From a iceberg user perspective, if I had a running iceberg data pipeline, I might not ever going to change/move away from deprecated one.
So in a worst case scenario for a given table with OBJECT_STORE_PATH or WRITE_FOLDER_STORAGE_LOCATION is set and its value is not equal to WRITE_DATA_LOCATION, shall we abort the write to force user action?
I think current logic is ignoring the old table properties and directly write into default, I think it might be reasonable but want to know if this is intended. Maybe we can raise the awareness on dev list about the change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was digging into this for PyIceberg, this has been deprecated since 0.12.0