Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): add cicd_deployments table, update github/gitlab's entities #671

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Nov 6, 2023

Please complete ALL items in this checklist, and remove before submitting

  • I have npm run build and npm run serve locally before submitting this PR
  • I have read through the Contributing Documentation

Summary

Does this close any open issues?

Closes N/A

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@d4x1 d4x1 requested a review from Startrekzky November 6, 2023 13:04
| `result` | varchar | 100 | The result of the deployment, e.g. SUCCESS, FAILURE | |
| `status` | varchar | 100 | The status of this deployment, e.g. IN_PROGRESS, DONE | |
| `environment` | varchar | 255 | The environment to deploy, only 'PRODUCTION' deployment will appear in v0.17 | |
| `created_date` | datetime | 3 | The created time of the deployment. Deprecated. | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will not deprecate this field, in fact, we'll get it supported in #6132

| `name` | varchar | 255 | The name of the deployment | |
| `result` | varchar | 100 | The result of the deployment, e.g. SUCCESS, FAILURE | |
| `status` | varchar | 100 | The status of this deployment, e.g. IN_PROGRESS, DONE | |
| `environment` | varchar | 255 | The environment to deploy, only 'PRODUCTION' deployment will appear in v0.17 | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the 'in v0.17' part

@@ -508,6 +508,27 @@ A cicd_task is the abstraction of the bottom-level CI/CD excecution.
| `finished_date` | datetime | 3 | When this task finished | | |
| `cicd_scope_id` | longtext | | The id of cicd_scope this task belongs to | FK_cicd_scopes.id |

#### cicd_deployments
A cicd_deployment is a deployment in a specific repo. It may come from several sources:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not correct, a cicd_deployment is not a deployment in a specific repo. You can refer to the following texts:

A cicd_deployment refers to a deployment at the project level. In the case where a pipeline run or build deploys across three distinct repositories, it will be categorized as ONE cicd_deployment while being recorded as THREE separate cicd_deployment_commits.

Copy link
Contributor

@Startrekzky Startrekzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Startrekzky Startrekzky merged commit 2ec5065 into apache:main Nov 7, 2023
@d4x1 d4x1 deleted the lw-add-deployment branch November 8, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants