-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(website): add cicd_deployments table, update github/gitlab's entities #671
Conversation
| `result` | varchar | 100 | The result of the deployment, e.g. SUCCESS, FAILURE | | | ||
| `status` | varchar | 100 | The status of this deployment, e.g. IN_PROGRESS, DONE | | | ||
| `environment` | varchar | 255 | The environment to deploy, only 'PRODUCTION' deployment will appear in v0.17 | | | ||
| `created_date` | datetime | 3 | The created time of the deployment. Deprecated. | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will not deprecate this field, in fact, we'll get it supported in #6132
| `name` | varchar | 255 | The name of the deployment | | | ||
| `result` | varchar | 100 | The result of the deployment, e.g. SUCCESS, FAILURE | | | ||
| `status` | varchar | 100 | The status of this deployment, e.g. IN_PROGRESS, DONE | | | ||
| `environment` | varchar | 255 | The environment to deploy, only 'PRODUCTION' deployment will appear in v0.17 | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the 'in v0.17' part
@@ -508,6 +508,27 @@ A cicd_task is the abstraction of the bottom-level CI/CD excecution. | |||
| `finished_date` | datetime | 3 | When this task finished | | | | |||
| `cicd_scope_id` | longtext | | The id of cicd_scope this task belongs to | FK_cicd_scopes.id | | |||
|
|||
#### cicd_deployments | |||
A cicd_deployment is a deployment in a specific repo. It may come from several sources: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not correct, a cicd_deployment is not a deployment in a specific repo. You can refer to the following texts:
A cicd_deployment refers to a deployment at the project level. In the case where a pipeline run or build deploys across three distinct repositories, it will be categorized as ONE cicd_deployment while being recorded as THREE separate cicd_deployment_commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
npm run build
andnpm run serve
locally before submitting this PRSummary
Does this close any open issues?
Closes N/A
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.