Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix_1960] Always setting enter date #1961

Merged
merged 1 commit into from
Jan 19, 2024
Merged

[Fix_1960] Always setting enter date #1961

merged 1 commit into from
Jan 19, 2024

Conversation

fjtirado
Copy link
Contributor

Fixes #1960

porcelli
porcelli approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@porcelli porcelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me

@pefernan
Copy link
Contributor

@fjtirado please don't merge this! I'd like to test it tomorrow morning.

@ederign
Copy link
Member

ederign commented Jan 18, 2024

@pefernan @porcelli , thank you so much for reviewing this on short notice. Are you ok if we merge it as soon as we have a green build ?

pefernan
pefernan approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@pefernan pefernan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go for it. I'll give it a test tomorrow and will let you know if there's a side effect.

@porcelli
Copy link
Member

@ederign yeah - I'm good with merging as soon as green

@ederign
Copy link
Member

ederign commented Jan 18, 2024

Thank you so much guys!

@ederign ederign merged commit 2bb2013 into apache:main Jan 19, 2024
4 of 5 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-apps that referenced this pull request Jan 25, 2024
@fjtirado @rgdoliveira
[Fix_1960] Always setting enter date (apache#1961)
46d8976
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagodolphine tiagodolphine tiagodolphine approved these changes

@pefernan pefernan pefernan approved these changes

@caponetto caponetto caponetto approved these changes

@ederign ederign ederign approved these changes

@porcelli porcelli porcelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enter field is null for node when event type is error
6 participants
@fjtirado @pefernan @ederign @porcelli @caponetto @tiagodolphine