-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1178 - Remove Kogito Operator pipelines and references #1179
Conversation
@ricardozanini IMHO the example images were exclusively for operator BDD tests. Let's ask @radtriste to confirm and we could get rid of it already. |
As far as I remember, they were mostly used for the bdd tests. We were indeed pushing them but I don't think that we were mentioning them into the documentation and/or examples' readmes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@radtriste @jstastny-cz many thanks for the updates! I'll remove the Jenkins Node and the BDD tests. I'll also squash this commit to make it easier to grab anything back if needed. |
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
90a4cee
to
5117374
Compare
@jstastny-cz @radtriste can you please take a look to make sure that my exclusions are alright? Thank you! |
See apache/incubator-kie-kogito-operator#1537
I've kept the node and the image that builds the operator 'cause we reuse it for the SonataFlow operator too.
Also, the example-images pipeline CAN be disabled since we only use it for the Kogito Operator BDD. But we need a new assessment on it to understand if they are being used somewhere else. We can open another PR to take care of it.