[incubator-kie-issues#828] Create zip files for source code #1202

cimbalek · 2024-05-22T15:45:44Z

Add bash script that creates zip files with sources as required by Apache

This is being tested here (in queue):
https://ci-builds.apache.org/job/KIE/job/tools/job/zip-sources/

.ci/jenkins/scripts/bash/zip-sources-all.sh

baldimir · 2024-05-23T07:48:09Z

.ci/jenkins/scripts/bash/zip-sources-all.sh

+
+    #Creating ZIP
+    pushd ${SOURCES_DIRECTORY_NAME}
+    ZIP_FILE_NAME="${REPO_NAME}-sources-${VERSION}.zip"


Please create one zip file instead of a zip file for each repository. There should be one big zip file with all sources. Filename should be in the format of incubator-kie-${params.VERSION_NUMBER}.zip

Please come to an agreement with Alex @porcelli

That screenshot is from February. Please see the release document here https://docs.google.com/document/d/1t-08b970i9PMBy-TSM64x0RUH46pzwnIhEi-LVeL0lg/edit. (I edited the version template for the file name based on that in my previous comment). More specifically, please see "AUTOMATION D: Release candidate job on Jenkins", section with Artifacts.

It's from february but since I gathered the information noone notified me about changes in the requirements. There was very few information about it.
apache/incubator-kie-issues#828

it has to be one big zip file as mentioned by @baldimir

examples and quickstart are not part of the release. as also pointed out by @cimbalek please check the release document

It was presented multiple times on the KIE weekly call and also on the dev mailing list (the release procedure was discussed there).

btw: the list of repos is already on the jenkinsfile that I shared

I'll adjust the list. I had the script long done already by the time jenkinsfile got to me.

baldimir

Please see my comments.

cimbalek · 2024-05-23T08:58:04Z

@baldimir I have several questions based on the document you sent

In the document you linked I see 7 repositoritories. Should I remove the ones that are not mentioned there? (incubator-kie-kogito-serverless-operator, incubator-kie-optaplanner-quickstarts, incubator-kie-kogito-examples, incubator-kie-kogito-online)
(already got answered in the meantime)
Automation D: There is list of container images. Should container-images-sources.zip match this list? And are container sources packed separately even needed given the kie-tools and kogito-images are already present in sources.zip? If the answer is yes, there will be a follow-up questions.

baldimir · 2024-05-23T09:10:31Z

@cimbalek please see Alex's reply here #1202 (comment)

The sources zip should be 1 zip with those 7 repositories. I would say, just clone those repositories and zip them. I don't think there is any need to delete anything from those repositories.

cimbalek · 2024-05-23T09:21:29Z

@baldimir I saw it. It got answered in the meantime. I understand it that packing container sources separately (or copying them into separate folder inside the zip) is not needed then.

Add bash script that creates zip files with sources as required by Apache

cimbalek · 2024-06-14T17:29:04Z

Should be ready now.

Summary of the whole PR now:

Added shell script for zipping sources
Added pipeline that uses the script ^^, signs resulting zip and uploads to SVN (signing and uploading is commented out as we are still waiting for credentials ATM)
Added job dsl to create a pipeline job that does the zipping. It'll be currently located in ...KIE/kogito/<branch>/tools/zip-and-upload-sources because of the limitations of the current framework and because of planned structural changes.

Seed jobs cascade[0][1] that generates zipping sources pipeline was successfully ran in my fork:

Actual pipeline run can be found here [2]. Resulting zip is available as archived artifacts [3]. Job failed because there was no signature to archive as the signing and uploading functionality is currently disabled.

Unless there are another change requests, I consider this PR ready from my side.

jstastny-cz

Wrong library reference and a few minor things.

.ci/jenkins/Jenkinsfile.zip.sources

tools/zip-sources-all.sh

.ci/jenkins/Jenkinsfile.zip.sources

cimbalek · 2024-06-28T17:21:44Z

Updated according to the discussion above. Test run is here:
https://ci-builds.apache.org/job/KIE/job/test/job/mcimbalek/job/playground/job/kie-issues-828/job/kie-issues-828/job/tools/job/0-zip-and-upload-sources/6/

.ci/jenkins/dsl/jobs.groovy

Co-authored-by: Jan Stastny <[email protected]>

cimbalek requested a review from jstastny-cz May 22, 2024 15:45

cimbalek changed the title ~~WIP: [incubator-kie-issues#828] Create zip files for source code~~ [incubator-kie-issues#828] Create zip files for source code May 23, 2024

cimbalek mentioned this pull request May 23, 2024

[Release Automation] Extend release pipeline creating zip files for source code as required by Apache apache/incubator-kie-issues#828

Closed

cimbalek requested a review from porcelli May 23, 2024 04:27

baldimir reviewed May 23, 2024

View reviewed changes

.ci/jenkins/scripts/bash/zip-sources-all.sh Outdated Show resolved Hide resolved

baldimir reviewed May 23, 2024

View reviewed changes

.ci/jenkins/scripts/bash/zip-sources-all.sh Outdated Show resolved Hide resolved

baldimir reviewed May 23, 2024

View reviewed changes

baldimir requested changes May 23, 2024

View reviewed changes

cimbalek force-pushed the main branch 2 times, most recently from 6e6edf1 to ef3bd22 Compare May 23, 2024 08:12

cimbalek requested a review from baldimir May 23, 2024 11:33

cimbalek force-pushed the main branch 2 times, most recently from 086b284 to 88e568b Compare May 23, 2024 11:43

baldimir approved these changes May 29, 2024

View reviewed changes

cimbalek changed the title ~~[incubator-kie-issues#828] Create zip files for source code~~ WIP: [incubator-kie-issues#828] Create zip files for source code May 29, 2024

cimbalek added 2 commits June 14, 2024 19:14

[incubator-kie-issues#828] Create zip files for source code

09e7b53

Add bash script that creates zip files with sources as required by Apache

[incubator-kie.issues#828] Add job definition for zip sources job

42f032a

cimbalek force-pushed the main branch from 88e568b to 42f032a Compare June 14, 2024 17:15

cimbalek changed the title ~~WIP: [incubator-kie-issues#828] Create zip files for source code~~ [incubator-kie-issues#828] Create zip files for source code Jun 14, 2024

cimbalek requested review from rodrigonull and removed request for porcelli June 17, 2024 11:14

rodrigonull approved these changes Jun 24, 2024

View reviewed changes

jstastny-cz reviewed Jun 26, 2024

View reviewed changes

.ci/jenkins/Jenkinsfile.zip.sources Outdated Show resolved Hide resolved

.ci/jenkins/Jenkinsfile.zip.sources Outdated Show resolved Hide resolved

tools/zip-sources-all.sh Outdated Show resolved Hide resolved

.ci/jenkins/Jenkinsfile.zip.sources Outdated Show resolved Hide resolved

cimbalek added 2 commits June 28, 2024 18:34

[drop-for-PR] Address suggestions and make script parametrized

745cbd4

[drop-for-PR] Comment out stage that signs and uploads sources.zip

c06ab93

jstastny-cz reviewed Jul 2, 2024

View reviewed changes

.ci/jenkins/dsl/jobs.groovy Outdated Show resolved Hide resolved

.ci/jenkins/dsl/jobs.groovy Outdated Show resolved Hide resolved

jstastny-cz approved these changes Jul 2, 2024

View reviewed changes

cimbalek and others added 2 commits July 2, 2024 13:04

Adjust parameter description

cbcd9fb

Co-authored-by: Jan Stastny <[email protected]>

Adjust parameter description

aaea59c

Co-authored-by: Jan Stastny <[email protected]>

cimbalek merged commit 56fd3f0 into apache:main Jul 2, 2024
2 checks passed

cimbalek mentioned this pull request Jul 2, 2024

[Release Automation] Create Jenkins jobs to upload sources.zip to https://dist.apache.org/repos/dist/dev/incubator/kie apache/incubator-kie-issues#815

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[incubator-kie-issues#828] Create zip files for source code #1202

[incubator-kie-issues#828] Create zip files for source code #1202

cimbalek commented May 22, 2024 •

edited

Loading

baldimir May 23, 2024 •

edited

Loading

cimbalek May 23, 2024 •

edited

Loading

baldimir May 23, 2024 •

edited

Loading

cimbalek May 23, 2024

porcelli May 23, 2024

baldimir May 23, 2024

porcelli May 23, 2024

cimbalek May 23, 2024

baldimir left a comment

cimbalek commented May 23, 2024 •

edited by baldimir

Loading

baldimir commented May 23, 2024

cimbalek commented May 23, 2024

cimbalek commented Jun 14, 2024 •

edited

Loading

jstastny-cz left a comment

cimbalek commented Jun 28, 2024

[incubator-kie-issues#828] Create zip files for source code #1202

[incubator-kie-issues#828] Create zip files for source code #1202

Conversation

cimbalek commented May 22, 2024 • edited Loading

baldimir May 23, 2024 • edited Loading

Choose a reason for hiding this comment

cimbalek May 23, 2024 • edited Loading

Choose a reason for hiding this comment

baldimir May 23, 2024 • edited Loading

Choose a reason for hiding this comment

cimbalek May 23, 2024

Choose a reason for hiding this comment

porcelli May 23, 2024

Choose a reason for hiding this comment

baldimir May 23, 2024

Choose a reason for hiding this comment

porcelli May 23, 2024

Choose a reason for hiding this comment

cimbalek May 23, 2024

Choose a reason for hiding this comment

baldimir left a comment

Choose a reason for hiding this comment

cimbalek commented May 23, 2024 • edited by baldimir Loading

baldimir commented May 23, 2024

cimbalek commented May 23, 2024

cimbalek commented Jun 14, 2024 • edited Loading

jstastny-cz left a comment

Choose a reason for hiding this comment

cimbalek commented Jun 28, 2024

cimbalek commented May 22, 2024 •

edited

Loading

baldimir May 23, 2024 •

edited

Loading

cimbalek May 23, 2024 •

edited

Loading

baldimir May 23, 2024 •

edited

Loading

cimbalek commented May 23, 2024 •

edited by baldimir

Loading

cimbalek commented Jun 14, 2024 •

edited

Loading