-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.0.x] NO-ISSUE: Fix drools version for nightly.quarkus-platform #1229
base: 10.0.x
Are you sure you want to change the base?
[10.0.x] NO-ISSUE: Fix drools version for nightly.quarkus-platform #1229
Conversation
|
Same for optaplanner branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'd check one thing here with the mailing list - if we still want to perform any steps towards being part of that platform. I mean, fixing pipelines is a good thing here, but I am not sure if we actually want to make it work. |
Sent to dev ML |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this was for legacy layout of branches/versions
just adding a link to the ML discussion thread https://lists.apache.org/thread/kzjw1o6rv58gd74mzzr11v6ymzw7khsb |
https://lists.apache.org/thread/kzjw1o6rv58gd74mzzr11v6ymzw7khsb The dev ML thread is still on-going. But at least, we are on the same page that this discussion shouldn't block 10.0 release. So we don't need to pass this |
Review by @pibizza "[REVIEW] [NOT OK] Current status for the kogito 10.x jobs"
It tries to check out branch
17.0.x
.getTargetBranch(7)
means adds the major version7
, which is probably an old approach when kogito version was1
and drools version was8
. Now, all projects aligns to10.0.x
.