Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing_ForEachRestIT #3304

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Fixing_ForEachRestIT #3304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90bf151
Fixing_ForEachRestIT
fjtirado Dec 1, 2023
6053bc4
Formatting
fjtirado Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...kflow-integration-test/src/main/java/org/kie/kogito/workflows/services/GreetResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@

import java.util.Map;

import org.kie.kogito.Model;
import org.kie.kogito.process.Process;

import jakarta.inject.Inject;
import jakarta.inject.Named;
import jakarta.ws.rs.GET;
Expand All @@ -28,9 +31,6 @@
import jakarta.ws.rs.core.MediaType;
import jakarta.ws.rs.core.Response;

import org.kie.kogito.Model;
import org.kie.kogito.process.Process;

@Path("/greetdetails")
public class GreetResource {

Expand Down
10 changes: 5 additions & 5 deletions ...ation-test/src/main/java/org/kie/kogito/workflows/services/JavaSerializationProducer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,16 @@
*/
package org.kie.kogito.workflows.services;

import jakarta.enterprise.context.ApplicationScoped;
import jakarta.enterprise.inject.Produces;
import jakarta.inject.Inject;
import jakarta.inject.Named;

import org.kie.kogito.addon.quarkus.messaging.common.ChannelFormat;
import org.kie.kogito.event.CloudEventUnmarshallerFactory;

import com.fasterxml.jackson.databind.ObjectMapper;

import jakarta.enterprise.context.ApplicationScoped;
import jakarta.enterprise.inject.Produces;
import jakarta.inject.Inject;
import jakarta.inject.Named;

@ApplicationScoped
public class JavaSerializationProducer {

Expand Down
4 changes: 2 additions & 2 deletions ...est/src/main/java/org/kie/kogito/workflows/services/NodeInstanceTriggerEventListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@
*/
package org.kie.kogito.workflows.services;

import jakarta.enterprise.context.ApplicationScoped;

import org.kie.api.event.process.ProcessNodeLeftEvent;
import org.kie.kogito.internal.process.event.DefaultKogitoProcessEventListener;
import org.kie.kogito.internal.process.runtime.KogitoNodeInstance;

import jakarta.enterprise.context.ApplicationScoped;

import static java.lang.String.format;

@ApplicationScoped
Expand Down
4 changes: 2 additions & 2 deletions ...ration-test/src/main/java/org/kie/kogito/workflows/services/RPCCustomWorkItemHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@

import java.util.Map;

import jakarta.enterprise.context.ApplicationScoped;

import org.kie.kogito.internal.process.runtime.KogitoWorkItem;
import org.kie.kogito.serverless.workflow.WorkflowWorkItemHandler;

import jakarta.enterprise.context.ApplicationScoped;

@ApplicationScoped
public class RPCCustomWorkItemHandler extends WorkflowWorkItemHandler {

Expand Down
6 changes: 3 additions & 3 deletions ...-test/src/main/java/org/kie/kogito/workflows/services/RPCCustomWorkItemHandlerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
*/
package org.kie.kogito.workflows.services;

import jakarta.enterprise.context.ApplicationScoped;
import jakarta.inject.Inject;
import org.kie.kogito.process.impl.CachedWorkItemHandlerConfig;

import jakarta.annotation.PostConstruct;
import org.kie.kogito.process.impl.CachedWorkItemHandlerConfig;
import jakarta.enterprise.context.ApplicationScoped;
import jakarta.inject.Inject;

@ApplicationScoped
public class RPCCustomWorkItemHandlerConfig extends CachedWorkItemHandlerConfig {
Expand Down
2 changes: 1 addition & 1 deletion ...rkflow-integration-test/src/test/java/org/kie/kogito/quarkus/workflows/ForEachRestIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ void testForEachSubflow() {
given()
.contentType(ContentType.JSON)
.accept(ContentType.JSON)
.body("{\"numbers\" : [1,2,3,4,5], \"constant\": 2}}").when()
.body("{\"numbers\" : [1,2,3,4,5], \"constant\": 2}").when()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the typo

.post("/foreach_parent")
.then()
.statusCode(201)
Expand Down
4 changes: 2 additions & 2 deletions ...-workflow-integration-test/src/test/java/org/kie/kogito/quarkus/workflows/SubFlowsIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@
import java.time.Duration;
import java.util.UUID;

import jakarta.ws.rs.core.MediaType;

import org.junit.jupiter.api.Test;

import io.quarkus.test.junit.QuarkusIntegrationTest;
import io.restassured.RestAssured;
import io.restassured.http.ContentType;

import jakarta.ws.rs.core.MediaType;

import static io.restassured.RestAssured.given;
import static org.awaitility.Awaitility.await;
import static org.hamcrest.CoreMatchers.is;
Expand Down
4 changes: 2 additions & 2 deletions .../src/test/java/org/kie/kogito/quarkus/workflows/TokenPropagationExternalServicesMock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@
import java.util.Collections;
import java.util.Map;

import jakarta.ws.rs.core.HttpHeaders;

import com.github.tomakehurst.wiremock.WireMockServer;

import io.quarkus.test.common.QuarkusTestResourceLifecycleManager;

import jakarta.ws.rs.core.HttpHeaders;

import static com.github.tomakehurst.wiremock.client.WireMock.aResponse;
import static com.github.tomakehurst.wiremock.client.WireMock.configureFor;
import static com.github.tomakehurst.wiremock.client.WireMock.equalTo;
Expand Down
4 changes: 2 additions & 2 deletions ...w-integration-test/src/test/java/org/kie/kogito/quarkus/workflows/TokenPropagationIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@
import java.util.HashMap;
import java.util.Map;

import jakarta.ws.rs.core.HttpHeaders;

import org.assertj.core.api.Assertions;
import org.junit.jupiter.api.Test;

import io.quarkus.test.common.QuarkusTestResource;
import io.quarkus.test.junit.QuarkusIntegrationTest;
import io.restassured.path.json.JsonPath;

import jakarta.ws.rs.core.HttpHeaders;

import static org.kie.kogito.quarkus.workflows.ExternalServiceMock.SUCCESSFUL_QUERY;
import static org.kie.kogito.quarkus.workflows.TokenPropagationExternalServicesMock.AUTHORIZATION_TOKEN;
import static org.kie.kogito.quarkus.workflows.TokenPropagationExternalServicesMock.SERVICE3_AUTHORIZATION_TOKEN;
Expand Down
2 changes: 1 addition & 1 deletion ...flow-integration-test/src/test/java/org/kie/kogito/quarkus/workflows/WorkflowEventIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ void testWorkflowEvents() throws Exception {
String password = "buddy";

kafkaClient.consume(Set.of(EventPublisher.PROCESS_INSTANCES_TOPIC_NAME), s -> {
LOGGER.info("Received from kafka: {}", s);
LOGGER.debug("Received from kafka: {}", s);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be debug

try {
ProcessInstanceDataEvent<?> event = mapper.readValue(s, ProcessInstanceDataEvent.class);
Map data = (Map) event.getData();
Expand Down
Loading