Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues-1306] Exclusive gateway v7 port #3551

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

elguardian
Copy link
Contributor

@apache apache deleted a comment from kie-ci3 Jun 21, 2024
@elguardian elguardian force-pushed the incubator-kie-issues-1306 branch from b2e9d29 to 186be93 Compare June 21, 2024 06:34
@elguardian elguardian marked this pull request as ready for review June 21, 2024 06:34
@elguardian elguardian force-pushed the incubator-kie-issues-1306 branch from 034eeac to 9d87851 Compare July 19, 2024 09:55
@apache apache deleted a comment from kie-ci3 Jul 19, 2024
@elguardian elguardian force-pushed the incubator-kie-issues-1306 branch from 9d87851 to 4a7ea73 Compare July 19, 2024 10:34
@apache apache deleted a comment from kie-ci3 Jul 19, 2024
@apache apache deleted a comment from kie-ci3 Jul 22, 2024
Copy link
Contributor

@pefernan pefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 when green. I only left a comment to clarify, everything else seems fine.

@@ -55,6 +56,12 @@ public class ActionNodeVisitor extends AbstractNodeVisitor<ActionNode> {

private static final String INTERMEDIATE_COMPENSATION_TYPE = "IntermediateThrowEvent-None";

private ReturnValueEvaluatorBuilderService returnValueEvaluatorBuilderService;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed? I don't see it's being used.

@elguardian elguardian requested a review from martinweiler July 23, 2024 06:31
Copy link
Contributor

@martinweiler martinweiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elguardian in addition to my comment on FlowTest#testConditionalFlow - I'd expect the process to execute start > script > end1 only, but the following assertion fails as the other end nodes are executed as well:

        assertThat(listener.tracked())
                .anyMatch(ProcessTestHelper.triggered("start"))
                .anyMatch(ProcessTestHelper.triggered("script"))
                .anyMatch(ProcessTestHelper.triggered("end1"));
        assertThat(listener.tracked())
                .noneMatch(ProcessTestHelper.triggered("end2"));

Maybe I am missing something?!

@elguardian elguardian force-pushed the incubator-kie-issues-1306 branch from 4a7ea73 to ed42466 Compare July 26, 2024 09:53
@apache apache deleted a comment from kie-ci3 Jul 26, 2024
Copy link
Contributor

@martinweiler martinweiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @elguardian

One question: previously, users could set the jbpm.enable.multi.con system property. Now it seems you need to define this as metadata property element on the process definition itself, unless you define the system property at compile time (I am not sure exactly how this would need to be done). Setting it at runtime won't be too late, as the process generation already failed - correct?

@elguardian
Copy link
Contributor Author

@martinweiler you are correct. runtime is too late as the code was generated already (failed because the flag was not defined)

@elguardian elguardian force-pushed the incubator-kie-issues-1306 branch from ed42466 to e1eb0c8 Compare July 29, 2024 06:51
@apache apache deleted a comment from kie-ci3 Jul 29, 2024
@elguardian elguardian force-pushed the incubator-kie-issues-1306 branch from 96de253 to 0e0c4a9 Compare July 29, 2024 10:34
@apache apache deleted a comment from kie-ci3 Jul 29, 2024
@elguardian elguardian merged commit 833a42e into apache:main Jul 29, 2024
5 of 6 checks passed
@elguardian elguardian deleted the incubator-kie-issues-1306 branch July 29, 2024 12:13
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclusive gateway v7 port
3 participants