[incubator-kie-issues-1555] Multiple sub process instances cancelled by the same timer. #3745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elguardian
force-pushed
the
incubator-kie-issues-1555
branch
2 times, most recently
from
0afee63 to
434aebc
Compare
martinweiler
requested changes
Oct 30, 2024
There was a problem hiding this comment.
@elguardian great work!
Some feedback:
- The sample application (run in the compact arch example) finishes successfully with the latest changes
- The newly added test
testMultiInstanceLoopSubprocessBoundaryTimerworks even without the fixes - I see the same test failure as in CI -
IntermediateEventTest.testIntermediateCatchEventSignalAndBoundarySignalEvent:1777
…by the same timer.
elguardian
force-pushed
the
incubator-kie-issues-1555
branch
from
ecf7c93 to
e9b3f4a
Compare
martinweiler
approved these changes
Oct 31, 2024
porcelli
approved these changes
Nov 1, 2024
rgdoliveira
pushed a commit
to rgdoliveira/kogito-runtimes
that referenced
this pull request
Nov 7, 2024
…by the same timer. (apache#3745) * [incubator-kie-issues-1555] Multiple sub process instances cancelled by the same timer. * fix tests * fix Composite rest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: apache/incubator-kie-issues#1555