[Fix #3763] Properly reading compressdata string header #3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmunozfe
approved these changes
Nov 5, 2024
...events-core/src/main/java/org/kie/kogito/event/process/MultipleProcessInstanceDataEvent.java
Show resolved
Hide resolved
...events-core/src/main/java/org/kie/kogito/event/process/MultipleProcessInstanceDataEvent.java
Show resolved
Hide resolved
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3764 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3764/1/display/redirect Test results:
Those are the test failures: |
wmedvede
approved these changes
Nov 5, 2024
rgdoliveira
pushed a commit
to rgdoliveira/kogito-runtimes
that referenced
this pull request
Nov 7, 2024
…#3764) * [Fix apache#3763] Properly reading compressdata string header * [Fix apache#3763] Adding unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3763
The quarkiverse extension returns all headers as string ( see https://github.com/quarkiverse/quarkus-reactive-messaging-http/blob/main/runtime/src/main/java/io/quarkus/reactivemessaging/http/runtime/HttpCloudEventHelper.java#L106 and https://github.com/quarkiverse/quarkus-reactive-messaging-http/blob/main/runtime/src/main/java/io/quarkus/reactivemessaging/http/runtime/HttpCloudEventHelper.java#L72), so the code to identify if the byte array is compressed should be adapted to that