Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-kogito-runtimes-3770: Use the workflow id as the auto-generated value for the name, when the workflow definition has no value in the attribute name #3771

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

wmedvede
Copy link
Contributor

Many thanks for submitting your Pull Request ❤️!

Closes: #3770

Description:

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to this configuration
  • Pull Request title is properly formatted: Issue-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

…nerated value for the name, when the workflow definition has no value in the attribute name
@gmunozfe gmunozfe self-requested a review November 13, 2024 13:31
Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done @wmedvede !

@fjtirado fjtirado merged commit 5876428 into apache:main Nov 13, 2024
6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Nov 13, 2024
…nerated value for the name, when the workflow definition has no value in the attribute name (apache#3771)
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Nov 13, 2024
…alue for the name, when the workflow definition has no value in the attribute name (apache#3771)
wmedvede added a commit to wmedvede/kogito-runtimes that referenced this pull request Nov 13, 2024
…nerated value for the name, when the workflow definition has no value in the attribute name (apache#3771)

(cherry picked from commit 5876428)
rgdoliveira pushed a commit to kiegroup/kogito-runtimes that referenced this pull request Nov 13, 2024
…nerated value for the name, when the workflow definition has no value in the attribute name (apache#3771) (#77)

(cherry picked from commit 5876428)
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Nov 18, 2024
…nerated value for the name, when the workflow definition has no value in the attribute name (apache#3771)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants