-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[incubator-kie-issues#1534] Remove less.jar from errai-ui #2664
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution @mcruzdev . As the removed file is in test resources and the build is green, I believe it is safe to approve even without manual check.
@jomarko Please notice that the build didn't start for this PR |
@yesamer ok, thank you for spottting, so, can we start it manually? |
@jomarko Yes |
I found by reference using the jar, but there is no. |
@mcruzdev thank you, still we need to run build to be 100%sure the changes are fine. @yesamer I am not able to start the build manually, so if you are able to do it, please help. @mcruzdev for example here you can see, the number of checks that should be started is higher #2658 I guess it is related to the thing, you are not member of the github apache organization and that is why jobs were not started probably. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, everything is ok. Thank you @mcruzdev
Not sure why the |
I will to try close and reopen |
Thanks @mcruzdev. |
I think it happened because I opened as draft, maybe.
|
I started a reserach here to solve the vscode-extension-tester issue, I think that it was solved 🎉 |
@porcelli I removed this one from the test 😟, but the pipeline is ok! I will pay attention for next. |
Closes apache/incubator-kie-issues#1534