Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues#1534] Remove less.jar from errai-ui #2664

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev marked this pull request as ready for review October 15, 2024 04:10
@mcruzdev mcruzdev requested a review from tiagobento as a code owner October 15, 2024 04:10
Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution @mcruzdev . As the removed file is in test resources and the build is green, I believe it is safe to approve even without manual check.

@yesamer
Copy link
Contributor

yesamer commented Oct 15, 2024

@jomarko Please notice that the build didn't start for this PR

@jomarko jomarko self-requested a review October 15, 2024 08:03
@jomarko
Copy link
Contributor

jomarko commented Oct 15, 2024

@yesamer ok, thank you for spottting, so, can we start it manually?

@yesamer
Copy link
Contributor

yesamer commented Oct 15, 2024

@jomarko Yes

@mcruzdev
Copy link
Contributor Author

Thank you for this contribution @mcruzdev . As the removed file is in test resources and the build is green, I believe it is safe to approve even without manual check.

I found by reference using the jar, but there is no.

@jomarko
Copy link
Contributor

jomarko commented Oct 15, 2024

@mcruzdev thank you, still we need to run build to be 100%sure the changes are fine. @yesamer I am not able to start the build manually, so if you are able to do it, please help.

@mcruzdev for example here you can see, the number of checks that should be started is higher #2658

I guess it is related to the thing, you are not member of the github apache organization and that is why jobs were not started probably.

Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, everything is ok. Thank you @mcruzdev

@mcruzdev
Copy link
Contributor Author

Thank you @yesamer and @jomarko!

@tiagobento
Copy link
Contributor

Not sure why the CI :: Build jobs are not running... We need to wait for them to be sure.

@tiagobento tiagobento added the pr: DO NOT MERGE Draft PR, not ready for merging label Oct 15, 2024
@mcruzdev
Copy link
Contributor Author

I will to try close and reopen

@mcruzdev mcruzdev closed this Oct 15, 2024
@mcruzdev mcruzdev reopened this Oct 15, 2024
@tiagobento
Copy link
Contributor

Thanks @mcruzdev. CI :: Build jobs are running.

@mcruzdev
Copy link
Contributor Author

mcruzdev commented Oct 15, 2024

I think it happened because I opened as draft, maybe.

if: github.event.pull_request.draft == false

@mcruzdev
Copy link
Contributor Author

I started a reserach here to solve the vscode-extension-tester issue, I think that it was solved 🎉

@tiagobento tiagobento merged commit d08ba44 into apache:main Oct 18, 2024
19 checks passed
@mcruzdev mcruzdev deleted the rm-binaries branch October 18, 2024 04:33
@mcruzdev
Copy link
Contributor Author

@porcelli I removed this one from the test 😟, but the pipeline is ok! I will pay attention for next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: DO NOT MERGE Draft PR, not ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Maven and Gradle wrapper from source
4 participants