Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1635: DMN Editor can not reopen List expression #2851

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Kusuma04-dev
Copy link
Contributor

@Kusuma04-dev Kusuma04-dev commented Jan 13, 2025

closes apache/incubator-kie-issues#1635 DMN Editor can not reopen List expression
when we have created list expression and go back to home screen and opened dmn again then we are getting below error(not able to reopen the diagram) :
Before fix:
Screenshot 2025-01-13 at 11 35 57 AM

After fix:
Screenshot 2025-01-13 at 11 36 11 AM

Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Kusuma04-dev for your PR!

IINW, with this change the logic will automatically nest a List Expression inside the created List Expression, as shown in the below image

Screenshot 2025-01-13 at 08 43 12

This is not the expected behavior, we should keep the expression undefined so the user can manually assign the expression to set there.

Based on that, I think you should revert the change and continue your investigation, the bug is in another place, in my opinion.

@Kusuma04-dev
Copy link
Contributor Author

Thank you @Kusuma04-dev for your PR!

IINW, with this change the logic will automatically nest a List Expression inside the created List Expression, as shown in the below image

Screenshot 2025-01-13 at 08 43 12 This is not the expected behavior, we should keep the expression undefined so the user can manually assign the expression to set there.

Based on that, I think you should revert the change and continue your investigation, the bug is in another place, in my opinion.

Hi Yeser,Got it will investigate further.

@kbowers-ibm kbowers-ibm self-requested a review January 15, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DMN Editor can not reopen List expression
2 participants