Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Upgrade Maven to 3.9.9 #2871

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/incubator-kie-tools-ci-build.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ RUN curl -s "https://get.sdkman.io" | bash && \
source "$HOME/.sdkman/bin/sdkman-init.sh" && \
sdk install java 17.0.11-tem && \
sudo update-alternatives --install /usr/local/bin/java java $(which java) 1 && \
sdk install maven 3.9.6 && \
sdk install maven 3.9.9 && \
sudo update-alternatives --install /usr/local/bin/mvn mvn $(which mvn) 1 && \
sdk flush

Expand Down
2 changes: 1 addition & 1 deletion .github/actions/setup-env/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ runs:
- name: "Set up Maven"
uses: stCarolas/setup-maven@v5
with:
maven-version: 3.9.6
maven-version: 3.9.9

- uses: actions/setup-python@v5
with:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ To build and test all packages of the Apache KIE Tools project, you're going to

- Node `20` _(To install, follow these instructions: https://nodejs.org/en/download/package-manager/)_
- pnpm `9.3.0` _(To install, follow these instructions: https://pnpm.io/installation#using-npm)_
- Maven `3.9.6`
- Maven `3.9.9`
- Java `17`
- Go `1.22.9` _(To install, follow these instructions: https://go.dev/doc/install)_
- Python `3.12` _(To install, follow these instructions: https://www.python.org/downloads/)_
Expand Down
2 changes: 1 addition & 1 deletion devbox.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"packages": {
"temurin-bin-17": "17.0.9",
"nodejs": "22.11.0",
"maven": "3.9.6",
"maven": "3.9.9",
"kubernetes-helm": "3.13.3",
"gnumake": "4.4.1",
"go": "1.22.9",
Expand Down
44 changes: 36 additions & 8 deletions devbox.lock
Original file line number Diff line number Diff line change
Expand Up @@ -109,23 +109,51 @@
}
}
},
"[email protected].6": {
"last_modified": "2024-06-12T20:55:33Z",
"resolved": "github:NixOS/nixpkgs/a9858885e197f984d92d7fe64e9fff6b2e488d40#maven",
"[email protected].9": {
"last_modified": "2024-12-23T21:10:33Z",
"resolved": "github:NixOS/nixpkgs/de1864217bfa9b5845f465e771e0ecb48b30e02d#maven",
"source": "devbox-search",
"version": "3.9.6",
"version": "3.9.9",
"systems": {
"aarch64-darwin": {
"store_path": "/nix/store/anjg4vldn49by6biv5xnhqq1mg34pbf2-apache-maven-3.9.6"
"outputs": [
{
"name": "out",
"path": "/nix/store/skgavbzs2qnkf4sqr9fzdgpwym6cyz6w-maven-3.9.9",
"default": true
}
],
"store_path": "/nix/store/skgavbzs2qnkf4sqr9fzdgpwym6cyz6w-maven-3.9.9"
},
"aarch64-linux": {
"store_path": "/nix/store/x0b2lf5938xbqkmyy0dy3m5scbzhn758-apache-maven-3.9.6"
"outputs": [
{
"name": "out",
"path": "/nix/store/d2d8y3d3v0bghv6v59m6ln3m154sp93d-maven-3.9.9",
"default": true
}
],
"store_path": "/nix/store/d2d8y3d3v0bghv6v59m6ln3m154sp93d-maven-3.9.9"
},
"x86_64-darwin": {
"store_path": "/nix/store/w6crqg0hzr9ywg4nfkiqhkfy9rscq5pz-apache-maven-3.9.6"
"outputs": [
{
"name": "out",
"path": "/nix/store/kfg5rnrxx0a6xcfkcsvj4rmangcfg01s-maven-3.9.9",
"default": true
}
],
"store_path": "/nix/store/kfg5rnrxx0a6xcfkcsvj4rmangcfg01s-maven-3.9.9"
},
"x86_64-linux": {
"store_path": "/nix/store/21kyz6bqsr97gjd3lc8g600zc1cksd1d-apache-maven-3.9.6"
"outputs": [
{
"name": "out",
"path": "/nix/store/dqv2ipvqa1ngydsgv0bcqxfr4xdq6zi6-maven-3.9.9",
"default": true
}
],
"store_path": "/nix/store/dqv2ipvqa1ngydsgv0bcqxfr4xdq6zi6-maven-3.9.9"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion examples/process-compact-architecture/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ public class Offer {

- Java 17+ installed
- Environment variable JAVA_HOME set accordingly
- Maven 3.9.6+ installed
- Maven 3.9.9+ installed
- Docker and Docker Compose to run the required example infrastructure.

And when using native image compilation, you will also need:
Expand Down
2 changes: 1 addition & 1 deletion examples/process-user-tasks-subsystem/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ You will need:

- Java 17 installed
- Environment variable JAVA_HOME set accordingly
- Maven 3.9.6 installed
- Maven 3.9.9 installed

When using native image compilation, you will also need:

Expand Down
2 changes: 1 addition & 1 deletion examples/sonataflow-greeting/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ You will need:

- Java 17 installed
- Environment variable JAVA_HOME set accordingly
- Maven 3.9.6 installed
- Maven 3.9.9 installed

When using native image compilation, you will also need:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ COPY --chown=$USER_ID:$USER_ID dist-dev/quarkus-app $HOME_PATH/app/
COPY --chown=$USER_ID:$USER_ID dist-dev/settings.xml /tmp/kogito/.m2/settings.xml

# Pre-populate local Maven repository for faster startup
RUN ./mvnw -Dmaven=3.9.6 clean package -B -nsu --settings /tmp/kogito/.m2/settings.xml -Dmaven.test.skip -Dmaven.repo.local=/tmp/kogito/.m2/repository -Dquarkus.http.non-application-root-path=${ROOT_PATH}/q -Dquarkus.http.root-path=${ROOT_PATH} \
RUN ./mvnw -Dmaven=3.9.9 clean package -B -nsu --settings /tmp/kogito/.m2/settings.xml -Dmaven.test.skip -Dmaven.repo.local=/tmp/kogito/.m2/repository -Dquarkus.http.non-application-root-path=${ROOT_PATH}/q -Dquarkus.http.root-path=${ROOT_PATH} \
&& chgrp -R 0 $HOME_PATH/app && chmod -R g=u $HOME_PATH/app && chgrp -R 0 /tmp/kogito && chmod -R g=u /tmp/kogito && chgrp -R 0 /.m2 && chmod -R g=u /.m2

USER $USER_ID
Expand All @@ -39,4 +39,4 @@ EXPOSE 8080

ENTRYPOINT ["/bin/bash", "-c"]

CMD ["dev-deployment-upload-service && cp -r $HOME_PATH/app/. /tmp/app && cd /tmp/app && ./mvnw -Dmaven=3.9.6 quarkus:dev -o -s=/tmp/kogito/.m2/settings.xml -Dquarkus.analytics.disabled=true -Ddebug=false -Dmaven.repo.local=/tmp/kogito/.m2/repository -Dquarkus.http.non-application-root-path=${ROOT_PATH}/q -Dquarkus.http.root-path=${ROOT_PATH}"]
CMD ["dev-deployment-upload-service && cp -r $HOME_PATH/app/. /tmp/app && cd /tmp/app && ./mvnw -Dmaven=3.9.9 quarkus:dev -o -s=/tmp/kogito/.m2/settings.xml -Dquarkus.analytics.disabled=true -Ddebug=false -Dmaven.repo.local=/tmp/kogito/.m2/repository -Dquarkus.http.non-application-root-path=${ROOT_PATH}/q -Dquarkus.http.root-path=${ROOT_PATH}"]
4 changes: 2 additions & 2 deletions packages/kie-sandbox-fs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@
],
"scripts": {
"build:dev": "rimraf dist && pnpm copy:src",
"build:prod": "rimraf dist && pnpm copy:src && pnpm test",
"build:prod": "rimraf dist && pnpm copy:src && pnpm test-e2e",
"copy:src": "copyfiles -u 1 \"src/**/*.{js,ts}\" dist/",
"test": "run-script-if --ignore-errors \"$(build-env tests.ignoreFailures)\" --bool \"$(build-env tests.run)\" --then \"karma start --single-run --watch\""
"test-e2e": "run-script-if --ignore-errors \"$(build-env endToEndTests.ignoreFailures)\" --bool \"$(build-env endToEndTests.run)\" --then \"karma start --single-run --watch\""
},
"dependencies": {
"@isomorphic-git/idb-keyval": "^3.3.2",
Expand Down
2 changes: 1 addition & 1 deletion repo/KOGITO_UPGRADE_PROCESS.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ The suggested strategy is to check all:

To double-check that all the versions are correctly updated, please perform a search with grep (or the IDE-integrated search) if the old version is still referenced somewhere. As a key, you can use:

- The version number (eg. `17` for Java and `3.9.6` for Maven);
- The version number (eg. `17` for Java and `3.9.9` for Maven);
- OpenJDK references (`openjdk`);
- Apache Maven references (`apache-maven`);
- GitHub Action references (`java-version` and `maven-version`);
Expand Down
2 changes: 1 addition & 1 deletion repo/build-dependencies-versions.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"go": "1.22.9",
"java": "17",
"maven": "3.9.6",
"maven": "3.9.9",
"node": "22.13.1",
"pnpm": "9.3.0",
"python3": "3.12.2",
Expand Down
Loading