Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add round robin in remote module #622

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Conversation

xjlgod
Copy link
Contributor

@xjlgod xjlgod commented Nov 18, 2023

What this PR does:
Implement RoudRobin load balancing in the remoting module
Which issue(s) this PR fixes:
Fixes #583
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?:
NONE

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4330268) 37.28% compared to head (8a5b297) 37.46%.

Files Patch % Lines
pkg/remoting/loadbalance/loadbalance.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
+ Coverage   37.28%   37.46%   +0.17%     
==========================================
  Files         175      176       +1     
  Lines       11666    11702      +36     
==========================================
+ Hits         4350     4384      +34     
- Misses       6952     6954       +2     
  Partials      364      364              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xjlgod xjlgod force-pushed the feat-robin branch 2 times, most recently from 075dd44 to 9f4a51c Compare November 18, 2023 07:47
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 560829c into apache:master Dec 28, 2023
5 checks passed
@funky-eyes funky-eyes added this to the 1.3.0 milestone Dec 28, 2023
@slievrly slievrly modified the milestones: 1.3.0, 2.0.0 Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在remoting模块中实现RoundRobin负载均衡
6 participants