Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove session when send heart beat message failed #738

Merged
merged 11 commits into from
Dec 14, 2024
Merged

feat: remove session when send heart beat message failed #738

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d84f3c0
feat:add more linter
No-SilverBullet Nov 10, 2024
aaae50c
Merge pull request #1 from No-SilverBullet/feat/add_linter
No-SilverBullet Nov 10, 2024
0fc667d
feat:change golangclilint version to 1.57.x to support more linter
No-SilverBullet Nov 10, 2024
6a4bebe
Merge pull request #2 from No-SilverBullet/feat/add_linter
No-SilverBullet Nov 10, 2024
358f4ac
feat:adjust lint conf and adjust the code to pass the check
No-SilverBullet Nov 10, 2024
ac85f94
Merge pull request #3 from No-SilverBullet/feat/add_linter
No-SilverBullet Nov 10, 2024
5c23b6c
Merge branch 'master' into master
luky116 Dec 7, 2024
fd25729
Merge branch 'master' into master
luky116 Dec 7, 2024
202cd26
Merge branch 'master' into master
luky116 Dec 7, 2024
eb16366
Merge branch 'apache:master' into master
No-SilverBullet Dec 13, 2024
ce334f7
feat:close session when send heart beat message failed
No-SilverBullet Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions pkg/remoting/getty/listener.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,18 +115,22 @@ func (g *gettyClientHandler) OnMessage(session getty.Session, pkg interface{}) {

func (g *gettyClientHandler) OnCron(session getty.Session) {
log.Debug("session{%s} Oncron executing", session.Stat())
g.transferBeatHeart(session, message.HeartBeatMessagePing)
err := g.transferHeartBeat(session, message.HeartBeatMessagePing)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里要设置失败的心跳次数吗？

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

跟进 issue：#740

if err != nil {
log.Errorf("failed to send heart beat: {%#v}", err.Error())
g.sessionManager.releaseSession(session)
}
}

func (g *gettyClientHandler) transferBeatHeart(session getty.Session, msg message.HeartBeatMessage) {
func (g *gettyClientHandler) transferHeartBeat(session getty.Session, msg message.HeartBeatMessage) error {
rpcMessage := message.RpcMessage{
ID: int32(g.idGenerator.Inc()),
Type: message.GettyRequestTypeHeartbeatRequest,
Codec: byte(codec.CodecTypeSeata),
Compressor: 0,
Body: msg,
}
GetGettyRemotingInstance().SendASync(rpcMessage, session, nil)
return GetGettyRemotingInstance().SendASync(rpcMessage, session, nil)
}

func (g *gettyClientHandler) RegisterProcessor(msgType message.MessageType, processor processor.RemotingProcessor) {
Expand Down
Loading