-
Notifications
You must be signed in to change notification settings - Fork 482
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: get rid of external dependency by implementing generic Min/Max …
…functions (#2713)
- Loading branch information
Showing
6 changed files
with
147 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -69,6 +69,9 @@ jobs: | |
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: apache/skywalking-eyes/[email protected] | ||
| with: | ||
| config: .github/config/licenserc.yml | ||
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version-file: 'tests/gocase/go.mod' | ||
|
|
@@ -77,9 +80,6 @@ jobs: | |
| run: | | ||
| sudo apt update | ||
| sudo apt install -y clang-format-14 clang-tidy-14 | ||
| - uses: apache/skywalking-eyes/[email protected] | ||
| with: | ||
| config: .github/config/licenserc.yml | ||
| - name: Check with clang-format | ||
| id: check-format | ||
| run: ./x.py check format --clang-format-path clang-format-14 | ||
|
|
@@ -89,7 +89,6 @@ jobs: | |
| ./x.py check tidy -j $(nproc) --clang-tidy-path clang-tidy-14 --run-clang-tidy-path run-clang-tidy-14 | ||
| - name: Lint with golangci-lint | ||
| run: ./x.py check golangci-lint | ||
|
|
||
| - name: Prepare format patch | ||
| if: always() && steps.check-format.outcome != 'success' | ||
| run: | | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package util | ||
|
|
||
| import "cmp" | ||
|
|
||
| // Min returns the smaller of two values. | ||
| func Min[T cmp.Ordered](a, b T) T { | ||
| if a < b { | ||
| return a | ||
| } | ||
| return b | ||
| } | ||
|
|
||
| // Max returns the larger of two values. | ||
| func Max[T cmp.Ordered](a, b T) T { | ||
| if a > b { | ||
| return a | ||
| } | ||
| return b | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package util_test | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/apache/kvrocks/tests/gocase/util" | ||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestMin(t *testing.T) { | ||
| // Arrange | ||
| tests := []struct { | ||
| name string | ||
| a int | ||
| b int | ||
| expectedResult int | ||
| }{ | ||
| { | ||
| name: "a is smaller than b", | ||
| a: 1, | ||
| b: 2, | ||
| expectedResult: 1, | ||
| }, | ||
| { | ||
| name: "a is greater than b", | ||
| a: 2, | ||
| b: 1, | ||
| expectedResult: 1, | ||
| }, | ||
| { | ||
| name: "a is equal to b", | ||
| a: 1, | ||
| b: 1, | ||
| expectedResult: 1, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| // Act | ||
| result := util.Min(tt.a, tt.b) | ||
|
|
||
| //Assert | ||
| assert.Equal(t, tt.expectedResult, result) | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestMax(t *testing.T) { | ||
| // Arrange | ||
| tests := []struct { | ||
| name string | ||
| a int | ||
| b int | ||
| expectedResult int | ||
| }{ | ||
| { | ||
| name: "a is smaller than b", | ||
| a: 1, | ||
| b: 2, | ||
| expectedResult: 2, | ||
| }, | ||
| { | ||
| name: "a is greater than b", | ||
| a: 2, | ||
| b: 1, | ||
| expectedResult: 2, | ||
| }, | ||
| { | ||
| name: "a is equal to b", | ||
| a: 1, | ||
| b: 1, | ||
| expectedResult: 1, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| // Act | ||
| result := util.Max(tt.a, tt.b) | ||
|
|
||
| //Assert | ||
| assert.Equal(t, tt.expectedResult, result) | ||
| }) | ||
| } | ||
| } |