config update and fix formatting

apache · Jan 15, 2025 · c35bf88 · c35bf88
1 parent fbac462
commit c35bf88
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/kvrocks.conf b/kvrocks.conf
@@ -383,7 +383,7 @@ txn-context-enabled no
 # NOTE: This is an experimental feature. There might be some performance overhead when using this
 # feature, please be aware.
 # Default: disabled
-histogram-bucket-boundaries  10,20,40,60,80,100,150,250,350,500,750,1000,1500,2000,4000,8000
+# histogram-bucket-boundaries  10,20,40,60,80,100,150,250,350,500,750,1000,1500,2000,4000,8000
 
 ################################## TLS ###################################
 

diff --git a/src/stats/stats.h b/src/stats/stats.h
@@ -83,9 +83,7 @@ class Stats {
   BucketBoundaries bucket_boundaries;
   std::map<std::string, CommandHistogram> commands_histogram;
 
-  Config *config_ = nullptr;
-
-  Stats(Config *config);
+  explicit Stats(Config *config);
 
   void IncrCalls(const std::string &command_name);
   void IncrLatency(uint64_t latency, const std::string &command_name);
@@ -97,4 +95,7 @@ class Stats {
   static int64_t GetMemoryRSS();
   void TrackInstantaneousMetric(int metric, uint64_t current_reading);
   uint64_t GetInstantaneousMetric(int metric) const;
+
+private:
+  Config *config_ = nullptr;
 };
diff --git a/tests/cppunit/config_test.cc b/tests/cppunit/config_test.cc
@@ -130,9 +130,7 @@ TEST(Config, GetAndSet) {
       {"rocksdb.rate_limiter_auto_tuned", "yes"},
       {"rocksdb.compression_level", "32767"},
       {"rocksdb.wal_compression", "no"},
-#ifdef ENABLE_HISTOGRAMS
       {"histogram-bucket-boundaries", "10,100,1000,10000"},
-#endif
 
   };
   for (const auto &iter : immutable_cases) {