feat: support histograms for command latency statistics #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabunkosar-dd
changed the title
rabunkosar-dd
changed the title
rabunkosar-dd
changed the title
|
@rabunkosar-dd Thanks for your contribution. You use |
git-hulk
reviewed
Jan 15, 2025
git-hulk
reviewed
Jan 17, 2025
PragmaTwice
reviewed
Jan 17, 2025
PragmaTwice
reviewed
Jan 17, 2025
PragmaTwice
reviewed
Jan 17, 2025
Co-authored-by: Twice <[email protected]>
git-hulk
previously approved these changes
Jan 17, 2025
|
@rabunkosar-dd Could you please fix the lint issue? |
PragmaTwice
reviewed
Jan 20, 2025
git-hulk
approved these changes
Jan 22, 2025
PragmaTwice
approved these changes
Jan 22, 2025
|
Thank you for your contribution! |
Thanks for the feedbacks and patience @PragmaTwice and @git-hulk |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to build kvrocks with histogram support to breakdown the command latencies. Current statistics are based on the total latency and the command count, giving averages. For our use case, where tail latencies are very impactful, this was not sufficient to track the general performance of the instances.
It also adds a config parameter to define the bucket boundaries. I will also follow up with a PR to add similar support in kvrocks_exporter (and support additive histograms for prometheus).
The buckets are not additive and there is an implicit bucket that tracks values beyond the defined values (inf bucket).
I added a build paramater (ENABLE_HISTOGRAMS), when set to ON will compile the support into the binary.The feature is enabled if the config parameter defines a non-empty list of buckets that are coma separated