Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): enable the RESP3 potocol by default #2746

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

git-hulk
Copy link
Member

We have supported the RESP3 since 2.8.0 about a year ago. And now most libraries support the RESP3 protocol, so it is good to enable it by default.

This closes #2728.

kvrocks.conf Outdated Show resolved Hide resolved
@git-hulk git-hulk requested a review from PragmaTwice January 27, 2025 09:40
PragmaTwice
PragmaTwice previously approved these changes Jan 27, 2025
@PragmaTwice
Copy link
Member

func TestXXXWithRESP3(t *testing.T) {
	srv := util.StartServer(t, map[string]string{
		"resp3-enabled": "yes",
	})
	defer srv.Close()

Need to change to:

func TestXXXWithoutRESP3(t *testing.T) {
	srv := util.StartServer(t, map[string]string{
		"resp3-enabled": "no",
	})
	defer srv.Close()

@PragmaTwice
Copy link
Member

Also for redis.setresp(3);, should resp3 be default in scripting?

@git-hulk
Copy link
Member Author

@PragmaTwice Yes, a few test cases need to be fixed after switching to RESP3. Will do it later.

git-hulk and others added 3 commits January 28, 2025 22:38
We have supported the RESP3 since 2.8.0 about a year ago. And now most
libraries are supported RESP3 protocol, so it good to enable it by
default.
@git-hulk git-hulk force-pushed the enable-resp3-by-default branch from 3a14e17 to 28d9cbf Compare January 28, 2025 14:39
@git-hulk git-hulk requested a review from PragmaTwice January 28, 2025 15:00
@git-hulk git-hulk merged commit 88f1f3e into apache:unstable Jan 29, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resp3 should enabled by default
2 participants