Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.apache.commons:commons-compress from 1.25.0 to 1.26.0 #187

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 19, 2024

Bumps org.apache.commons:commons-compress from 1.25.0 to 1.26.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps org.apache.commons:commons-compress from 1.25.0 to 1.26.0.

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-compress
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Feb 19, 2024
@slawekjaranowski
Copy link
Member

There is a bug in invoker ... when we try to override dependencies version
Building classloader in invoker for pre and post script should be verified

@slawekjaranowski slawekjaranowski marked this pull request as draft February 19, 2024 20:45
@elharo
Copy link
Contributor

elharo commented Feb 24, 2024

FYI 1.26.0 has some notable bugs. We should wait for 1.26.1, and for other reasons I'm not sure that staying on 1.25.0 for longer is a bad idea.

@slawekjaranowski
Copy link
Member

@elharo thanks - I see an optional dependencies - please look for last commit

@elharo
Copy link
Contributor

elharo commented Feb 24, 2024

In fact it looks like at least some of the failures here are directly caused by known issues in commons-compress 1.26.0:

[INFO] ------------------------------------------------------------------------
Running post-build script: /home/jenkins/jenkins-home/workspace/box_maven-assembly-plugin_PR-187@2/linux-jdk8-m3.6.x_build/target/it/projects/bugs/massembly-731/verify.groovy
java.lang.NoClassDefFoundError: org/apache/commons/io/build/AbstractStreamBuilder
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:756)

I'm going to close this. Dependabot will tell us when 1.26.1 is ready and we can revisit.

@elharo elharo closed this Feb 24, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 24, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/org.apache.commons-commons-compress-1.26.0 branch February 24, 2024 14:12
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messages crossed in the ether. reopen if you still want this update, but my recommendation is to stick with 1.25 for now.

<version>1.25.0</version>
<version>1.26.0</version>
</dependency>
<dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do this add a comment that this is only needed for commons-compress optional reasons and we should take it out once they fix that.

@slawekjaranowski
Copy link
Member

ok, one class is used in groovy scripts - it is not important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants