-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNGSITE-541] Define project and subproject #652
Conversation
spotless is being annoying... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you rebase on master the spotless issues should go away.
This uses the definition created in the What's new in Maven 4 article.
b804d19
to
b551f23
Compare
I don't get it too. I'm sure I run spotless before I push. Maybe because there are daily snapshots of maven parent from staging repository which are pulled in?
However, rebased, applied again. |
It wasn't this PR's fault. There was a problem in another file in the repo that caused spotless to fail on all PRs even though that file wasn't edited in this PR. It's now fixed at head, and that's why rebasing let this PR pass. |
This uses the definition created in the What's new in Maven 4 article.