Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNGSITE-541] Define project and subproject #652

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

Bukama
Copy link
Contributor

@Bukama Bukama commented Jan 23, 2025

This uses the definition created in the What's new in Maven 4 article.

@elharo
Copy link
Contributor

elharo commented Jan 29, 2025

spotless is being annoying...

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you rebase on master the spotless issues should go away.

This uses the definition created in the What's new in Maven 4 article.
@Bukama Bukama force-pushed the MNGSITE-541_moduleandsubmodule branch from b804d19 to b551f23 Compare January 29, 2025 20:11
@Bukama
Copy link
Contributor Author

Bukama commented Jan 29, 2025

I think if you rebase on master the spotless issues should go away.

I don't get it too. I'm sure I run spotless before I push. Maybe because there are daily snapshots of maven parent from staging repository which are pulled in?

D:\Github\Maven\maven-site>mvn spotless:apply
[WARNING] Unable to find the root directory. Create a .mvn directory in the root directory or add the root="true" attribute on the root project's model to identify it.
[INFO] Scanning for projects...
Downloading from apache.snapshots: https://repository.apache.org/snapshots/org/apache/maven/maven-parent/44-SNAPSHOT/maven-metadata.xml
Downloading from apache.staging: https://repository.apache.org/content/repositories/maven-1906/org/apache/maven/maven-parent/44-SNAPSHOT/maven-metadata.xml
Downloaded from apache.snapshots: https://repository.apache.org/snapshots/org/apache/maven/maven-parent/44-SNAPSHOT/maven-metadata.xml (810 B at 9223372036854775807 GB/s)
Downloading from apache.staging: https://repository.apache.org/content/repositories/maven-1906/org/apache/apache/34-SNAPSHOT/maven-metadata.xml
Downloading from apache.snapshots: https://repository.apache.org/snapshots/org/apache/apache/34-SNAPSHOT/maven-metadata.xml
Downloaded from apache.snapshots: https://repository.apache.org/snapshots/org/apache/apache/34-SNAPSHOT/maven-metadata.xml (589 B at 9223372036854775807 GB/s)
[INFO]
[INFO] ----------------------------------------< org.apache.maven:maven-site >-----------------------------------------
[INFO] Building Apache Maven Site 1.0
[INFO]   from pom.xml
[INFO] ----------------------------------------------------[ jar ]-----------------------------------------------------
[INFO]
[INFO] --- spotless:2.44.2:apply (default-cli) @ maven-site ---
[INFO] Index file corresponds to a different configuration of the plugin. Either the plugin version or its configuration has changed. Fallback to an empty index
[INFO] Spotless.Java is keeping 1 files clean - 0 were changed to be clean, 1 were already clean, 0 were skipped because caching determined they were already clean
[INFO] Spotless.Pom is keeping 1 files clean - 0 were changed to be clean, 1 were already clean, 0 were skipped because caching determined they were already clean
[INFO] Spotless.Markdown is keeping 103 files clean - 0 were changed to be clean, 103 were already clean, 0 were skipped because caching determined they were already clean

However, rebased, applied again.

@elharo
Copy link
Contributor

elharo commented Jan 29, 2025

It wasn't this PR's fault. There was a problem in another file in the repo that caused spotless to fail on all PRs even though that file wasn't edited in this PR. It's now fixed at head, and that's why rebasing let this PR pass.

@elharo elharo merged commit 226ebd3 into apache:master Jan 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants