[MNGSITE-446] Properties file gets deleted by default. #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
reviewed
Jan 28, 2025
| by simply excuting the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again. | ||
| The <release.properties> file is created while preparing the release. The <release.properties> file can be given to any developer within the team and | ||
| by simply executing the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again. | ||
| By default the file gets deleted after a successful release. |
There was a problem hiding this comment.
so how is it reused then? I'm missing something here.
There was a problem hiding this comment.
I removed the part about reusing it completely, because it doesn't make sense in my opinion anymore, when the file gets removed by default. I was already thinking about this when creating the creating the PR, but decided against, because I was thinking maybe I'm the only one who thinks so. But your question shows me, that I'm not.
This said, I think that for the documentation we can go with "if you don't use the default, you know what you are doing with your properties-file".
elharo
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to docs of the plugin itself as well of my understanding of the plugin code myself, the clean phase is executed by default after a successful release by default (DefaultReleaseManager).
So I updated this in the docs on site.
Closes #MNGSITE-446.