SUREFIRE-2212: parse element content only if needed to prevent OOME

apache · Nov 17, 2023 · f04a308 · f04a308
1 parent 47c5816
commit f04a308
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/...ort-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java b/...ort-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java
@@ -60,6 +60,8 @@ public final class TestSuiteXmlParser extends DefaultHandler {
 
     private boolean valid;
 
+    private boolean parseContent;
+
     public TestSuiteXmlParser(ConsoleLogger consoleLogger) {
         this.consoleLogger = consoleLogger;
     }
@@ -157,12 +159,14 @@ public void startElement(String uri, String localName, String qName, Attributes
                         break;
                     case "failure":
                         currentElement = new StringBuilder();
+                        parseContent = true;
 
                         testCase.setFailure(attributes.getValue("message"), attributes.getValue("type"));
                         currentSuite.incrementNumberOfFailures();
                         break;
                     case "error":
                         currentElement = new StringBuilder();
+                        parseContent = true;
 
                         testCase.setError(attributes.getValue("message"), attributes.getValue("type"));
                         currentSuite.incrementNumberOfErrors();
@@ -181,6 +185,7 @@ public void startElement(String uri, String localName, String qName, Attributes
                         break;
                     case "time":
                         currentElement = new StringBuilder();
+                        parseContent = true;
                         break;
                     default:
                         break;
@@ -215,6 +220,7 @@ public void endElement(String uri, String localName, String qName) throws SAXExc
             default:
                 break;
         }
+        parseContent = false;
         // TODO extract real skipped reasons
     }
 
@@ -225,7 +231,7 @@ public void endElement(String uri, String localName, String qName) throws SAXExc
     public void characters(char[] ch, int start, int length) {
         assert start >= 0;
         assert length >= 0;
-        if (valid && isNotBlank(start, length, ch)) {
+        if (valid && parseContent && isNotBlank(start, length, ch)) {
             currentElement.append(ch, start, length);
         }
     }