Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sched: remove spin_lock_irqsave(NULL) support #15324

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

sched: remove spin_lock_irqsave(NULL) support #15324

wants to merge 2 commits into from
+12 −72

Conversation

hujun260
Copy link
Contributor

@hujun260 hujun260 commented Dec 24, 2024 •
edited
Loading

Summary

sched: remove spin_lock_irqsave(NULL) support

Impact

sched

Testing

ci

qemu-armv8a:nsh_smp

@github-actions github-actions bot added Area: Drivers Drivers issues Area: OS Components OS Components issues Size: M The size of the change in this PR is medium labels Dec 24, 2024
@yamt
Copy link
Contributor

yamt commented Dec 24, 2024

(this comment is not specific to this PR)
do you have a plan to document which lock protects what? it isn't so obvious to me.

anchao
anchao reviewed Dec 24, 2024
View reviewed changes
include/nuttx/spinlock.h Outdated Show resolved Hide resolved
sched/clock/clock_gettime.c Outdated Show resolved Hide resolved
include/nuttx/spinlock.h Outdated Show resolved Hide resolved
include/nuttx/spinlock.h Outdated Show resolved Hide resolved
sched/clock/clock_gettime.c Outdated Show resolved Hide resolved
sched/clock/clock_initialize.c Outdated Show resolved Hide resolved
sched/irq/irq_attach.c Outdated Show resolved Hide resolved
sched/mqueue/mq_msgfree.c Outdated Show resolved Hide resolved
sched/signal/sig_default.c Outdated Show resolved Hide resolved
sched/timer/timer_create.c Outdated Show resolved Hide resolved
@anchao anchao requested a review from masayuki2009 December 24, 2024 04:50
anchao
anchao reviewed Dec 24, 2024
View reviewed changes
include/nuttx/clock.h Outdated Show resolved Hide resolved
@hujun260
Copy link
Contributor Author

which lock protects wha

We replace a big lock with smaller locks. Generally, it's easy to find which lock protects what through file searching.

@yamt
Copy link
Contributor

yamt commented Dec 24, 2024

which lock protects wha

We replace a big lock with smaller locks. Generally, it's easy to find which lock protects what through file searching.

sometimes it's obvious. sometimes not.

anchao
anchao reviewed Dec 25, 2024
View reviewed changes
sched/clock/clock_initialize.c Outdated Show resolved Hide resolved
sched/clock/clock_settime.c Outdated Show resolved Hide resolved
sched/clock/clock_systime_timespec.c Outdated Show resolved Hide resolved
@github-actions github-actions bot added Arch: arm Issues related to ARM (32-bit) architecture Arch: renesas Issues related to the Renesas chips Arch: x86_64 Issues related to the x86_64 architecture labels Dec 25, 2024
@hujun260 hujun260 force-pushed the apache_53 branch 6 times, most recently from aa76d61 to acaa1ca Compare December 31, 2024 03:37
xiaoxiang781216
xiaoxiang781216 reviewed Jan 3, 2025
View reviewed changes
arch/renesas/src/rx65n/rx65n_rtc.c Outdated Show resolved Hide resolved
arch/renesas/src/rx65n/rx65n_rtc.c Outdated Show resolved Hide resolved
arch/x86_64/src/intel64/intel64_rtc.c Outdated Show resolved Hide resolved
arch/arm/src/stm32/stm32_eth.c Outdated Show resolved Hide resolved
arch/arm/src/sam34/sam_rtc.c Outdated Show resolved Hide resolved
arch/arm/src/sam34/sam_rtc.c Outdated Show resolved Hide resolved
sched/clock/clock_initialize.c Outdated Show resolved Hide resolved
sched/clock/clock_initialize.c Outdated Show resolved Hide resolved
sched/clock/clock_initialize.c Outdated Show resolved Hide resolved
sched/clock/clock_initialize.c Outdated Show resolved Hide resolved
@github-actions github-actions bot added Size: S The size of the change in this PR is small and removed Arch: arm Issues related to ARM (32-bit) architecture Arch: renesas Issues related to the Renesas chips Arch: x86_64 Issues related to the x86_64 architecture Area: Drivers Drivers issues Size: M The size of the change in this PR is medium labels Jan 7, 2025
@hujun260 hujun260 changed the title sched: remove all spin_lock_irqsave(NULL) sched: rm g_irq_spin and g_irq_spin_count Jan 7, 2025
@github-actions github-actions bot added Arch: arm Issues related to ARM (32-bit) architecture Area: Drivers Drivers issues Size: M The size of the change in this PR is medium and removed Size: S The size of the change in this PR is small labels Jan 8, 2025
@hujun260 hujun260 changed the title sched: rm g_irq_spin and g_irq_spin_count sched: remove spin_lock_irqsave(NULL) support Jan 8, 2025
@xiaoxiang781216
Copy link
Contributor

@hujun260 please rebase the patch to fix the conflict.

@github-actions github-actions bot added Size: S The size of the change in this PR is small and removed Area: Drivers Drivers issues Size: M The size of the change in this PR is medium labels Jan 10, 2025
@hujun260
Copy link
Contributor Author

@hujun260 please rebase the patch to fix the conflict.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 left review comments

@yamt yamt yamt left review comments

@anchao anchao anchao left review comments

@masayuki2009 masayuki2009 Awaiting requested review from masayuki2009

Assignees
No one assigned
Labels
Arch: arm Issues related to ARM (32-bit) architecture Area: OS Components OS Components issues Size: S The size of the change in this PR is small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hujun260 @yamt @xiaoxiang781216 @anchao