[core]Fix drop table in Hive and jdbc catalog when the file path does not exists. #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwj6591812
reviewed
Jan 8, 2025
| @@ -598,6 +595,10 @@ public Optional<TableSchema> tableSchemaInFileSystem(Path tablePath, String bran | |||
| }); | |||
| } | |||
|
|
|||
| protected boolean tableExists(Identifier identifier) { | |||
There was a problem hiding this comment.
private
In hive and jdbc catalog, tableExists method has different implement. So I used protected.
| Identifier.create(databaseName, tableName), DEFAULT_TABLE_SCHEMA, false); | ||
| JdbcCatalog jdbcCatalog = (JdbcCatalog) catalog; | ||
| Path path = jdbcCatalog.getTableLocation(Identifier.create(databaseName, tableName)); | ||
| // delete file path |
There was a problem hiding this comment.
Maybe "delete table path" is better?
| identifier.getDatabaseName(), identifier.getTableName())); | ||
| } catch (TException e) { | ||
| throw new RuntimeException( | ||
| "Cannot determine if table " + identifier.getFullName() + "exists.", e); |
| Identifier.create(databaseName, tableName), | ||
| addHiveTableParametersSchema, | ||
| false); | ||
| // delete file path |
| catalog.dropTable(Identifier.create(databaseName, tableName), false); | ||
| List<String> tables = catalog.listTables(databaseName); | ||
| assertThat(tableName).isNotIn(tables); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
This try statement is very big, maybe add "throw Exception" in the method signature is better?
|
What the relation between this pr and #4863? |
It seems we resloved same problem. In UTCase and ITCase Spark 4.x and Spark 3.x, it still has some problem which I not sure how to solve.I'll close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix drop table in Hive and jdbc catalog when the file path does not exists.
Linked issue: close #4853
Tests
API and Format
Documentation