-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][ci] Parameterize CI build so that Java 21 can be selected for manual runs #21400
Conversation
e2e386b
to
a34713d
Compare
…d for manual runs
a34713d
to
a1d15e3
Compare
Examples runs with Java 21 in my fork: |
Codecov Report
@@ Coverage Diff @@
## master #21400 +/- ##
=============================================
+ Coverage 36.69% 73.29% +36.60%
- Complexity 12228 32578 +20350
=============================================
Files 1711 1888 +177
Lines 130684 140298 +9614
Branches 14242 15420 +1178
=============================================
+ Hits 47957 102837 +54880
+ Misses 76382 29378 -47004
- Partials 6345 8083 +1738
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good approach to experience with Java21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Motivation
When preparing for Java 21, it is useful to be able to run the Pulsar build and tests with Java 21.
Modifications
Parameterize the JDK version in the GitHub Actions Pulsar CI workflow so that Java 21 can be selected when triggering the workflow manually:
Documentation
doc
doc-required
doc-not-needed
doc-complete