Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][ci] Parameterize CI build so that Java 21 can be selected for manual runs #21400

Merged
merged 1 commit into from
Oct 20, 2023
Merged

[improve][ci] Parameterize CI build so that Java 21 can be selected for manual runs #21400

merged 1 commit into from
Oct 20, 2023

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Oct 19, 2023

Motivation

When preparing for Java 21, it is useful to be able to run the Pulsar build and tests with Java 21.

Modifications

Parameterize the JDK version in the GitHub Actions Pulsar CI workflow so that Java 21 can be selected when triggering the workflow manually:
image

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.2.0 milestone Oct 19, 2023
@lhotari lhotari self-assigned this Oct 19, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 19, 2023
@lhotari lhotari requested review from nodece and eolivelli October 19, 2023 12:20
@lhotari lhotari changed the title [improve][build] Parameterize CI build so that Java 21 can be selected for manual runs [improve][ci] Parameterize CI build so that Java 21 can be selected for manual runs Oct 19, 2023
@lhotari lhotari force-pushed the lh-ci-build-option-java-21 branch from e2e386b to a34713d Compare October 19, 2023 17:03
@lhotari lhotari force-pushed the lh-ci-build-option-java-21 branch from a34713d to a1d15e3 Compare October 19, 2023 17:05
@lhotari
Copy link
Member Author

lhotari commented Oct 19, 2023

Examples runs with Java 21 in my fork:
Pulsar CI
https://github.com/lhotari/pulsar/actions/runs/6577911040
Pulsar CI Flaky
https://github.com/lhotari/pulsar/actions/runs/6577912350

@codecov-commenter
Copy link

Codecov Report

Merging #21400 (a1d15e3) into master (700a29d) will increase coverage by 36.60%.
Report is 5 commits behind head on master.
The diff coverage is 62.50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21400       +/-   ##
=============================================
+ Coverage     36.69%   73.29%   +36.60%     
- Complexity    12228    32578    +20350     
=============================================
  Files          1711     1888      +177     
  Lines        130684   140298     +9614     
  Branches      14242    15420     +1178     
=============================================
+ Hits          47957   102837    +54880     
+ Misses        76382    29378    -47004     
- Partials       6345     8083     +1738
Flag Coverage Δ
inttests 24.17% <0.00%> (+0.08%) ⬆️
systests 24.75% <0.00%> (+0.06%) ⬆️
unittests 72.59% <62.50%> (+40.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...dbalance/extensions/ExtensibleLoadManagerImpl.java 77.75% <100.00%> (+75.87%) ⬆️
...xtensions/channel/ServiceUnitStateChannelImpl.java 85.25% <100.00%> (+84.71%) ⬆️
...ache/pulsar/broker/namespace/NamespaceService.java 72.25% <ø> (+28.86%) ⬆️
...ava/org/apache/pulsar/broker/service/Consumer.java 86.23% <100.00%> (+23.58%) ⬆️
...org/apache/pulsar/broker/service/Subscription.java 69.23% <ø> (+61.53%) ⬆️
...rvice/nonpersistent/NonPersistentSubscription.java 53.53% <ø> (+25.25%) ⬆️
...ker/service/persistent/PersistentSubscription.java 76.24% <ø> (+26.39%) ⬆️
...sar/broker/service/persistent/PersistentTopic.java 79.34% <100.00%> (+27.30%) ⬆️
.../loadbalance/extensions/manager/UnloadManager.java 81.63% <40.00%> (+81.63%) ⬆️
...rg/apache/pulsar/broker/service/BrokerService.java 80.90% <33.33%> (+25.28%) ⬆️

... and 1444 files with indirect coverage changes

Technoboy-
Technoboy- approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good approach to experience with Java21

tisonkun
tisonkun approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun merged commit 772f16c into apache:master Oct 20, 2023
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@RobertIndie RobertIndie Awaiting requested review from RobertIndie

@nicoloboschi nicoloboschi Awaiting requested review from nicoloboschi

@mattisonchao mattisonchao Awaiting requested review from mattisonchao

@heesung-sn heesung-sn Awaiting requested review from heesung-sn

@nodece nodece Awaiting requested review from nodece

@eolivelli eolivelli Awaiting requested review from eolivelli

@hangc0276 hangc0276 Awaiting requested review from hangc0276

@cbornet cbornet Awaiting requested review from cbornet

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

Assignees

@lhotari lhotari

Labels
area/build area/ci doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lhotari @codecov-commenter @Technoboy- @tisonkun