[improve][ci] Improve thread leak detection by ignoring more Testcontainers threads #21499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
cbornet,
BewareMyPower,
tisonkun and
mattisonchao
lhotari
force-pushed
the
lh-ignore-more-testcontainer-threads
branch
from
9fc8f80 to
8525e87
Compare
lhotari
changed the title
lhotari
force-pushed
the
lh-ignore-more-testcontainer-threads
branch
from
8525e87 to
076fd55
Compare
cbornet
reviewed
Nov 1, 2023
| } | ||
| return false; | ||
| } | ||
|
|
||
| private static Runnable extractRunnableTarget(Thread thread) { |
There was a problem hiding this comment.
NIT: maybe add a comment on why we have to use reflection here.
cbornet
approved these changes
Nov 1, 2023
Codecov Report
@@ Coverage Diff @@
## master #21499 +/- ##
=============================================
+ Coverage 36.76% 73.30% +36.53%
- Complexity 12233 32626 +20393
=============================================
Files 1713 1890 +177
Lines 130816 140423 +9607
Branches 14258 15434 +1176
=============================================
+ Hits 48100 102931 +54831
+ Misses 76361 29398 -46963
- Partials 6355 8094 +1739
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nborisov
pushed a commit
to nborisov/pulsar
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The thread leak detection added in #21450 reports some Testcontainer threads as leaks. These threads can be safely ignored since they will be terminated eventually.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete