Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][ci] Disable stale bot #21549

Merged
merged 2 commits into from
Nov 10, 2023
Merged

[improve][ci] Disable stale bot #21549

merged 2 commits into from
Nov 10, 2023

Conversation

asafm
Copy link
Contributor

@asafm asafm commented Nov 9, 2023

Motivation

Stale bot generates more noise than attributing any value to maintaining PR and issues.
There was a discussion on this hence it's time to make the first step.

Modifications

Disable the GitHub workflow which triggers the stale check

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@asafm
Copy link
Contributor Author

asafm commented Nov 9, 2023

@tisonkun

Copy link

github-actions bot commented Nov 9, 2023

@asafm Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@tisonkun tisonkun changed the title [improve][build] Disable stale bot [improve][ci] Disable stale bot Nov 9, 2023
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps just delete the whole file?

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 9, 2023
@asafm
Copy link
Contributor Author

asafm commented Nov 9, 2023

@tisonkun Deleted it

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Open for a while to accept comments.

I'll merge this patch in the next monday if no more objection.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@nodece nodece merged commit f607313 into apache:master Nov 10, 2023
52 checks passed
nborisov pushed a commit to nborisov/pulsar that referenced this pull request Nov 13, 2023
@asafm asafm deleted the remove-stale-bot branch November 13, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants