Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][Offload] fix indexEntries NullPointerException error #22035

Closed
wants to merge 2 commits into from
Closed

[fix][Offload] fix indexEntries NullPointerException error #22035

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
113e88b
[fix][Offload] fix indexEntries is null error
Feb 6, 2024
507ada4
[fix][Offload] remove indexEntries.clear() to aviod NullPointerException
Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...rc/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/OffloadIndexBlockImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public class OffloadIndexBlockImpl implements OffloadIndexBlock {
private LedgerMetadata segmentMetadata;
private long dataObjectLength;
private long dataHeaderLength;
private TreeMap<Long, OffloadIndexEntryImpl> indexEntries;
private volatile TreeMap<Long, OffloadIndexEntryImpl> indexEntries;

private final Handle<OffloadIndexBlockImpl> recyclerHandle;

Expand Down Expand Up @@ -94,8 +94,10 @@ public void recycle() {
dataObjectLength = -1;
dataHeaderLength = -1;
segmentMetadata = null;
indexEntries.clear();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line cannot fix the root cause

indexEntries = null;
if (indexEntries != null) {
indexEntries.clear();
indexEntries = null;
}
if (recyclerHandle != null) {
recyclerHandle.recycle(this);
}
Expand Down
Loading