[improve][broker] Improve Consumer.equals performance #23864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- current problem is that unefficient IP address comparison will have to be performed on every match - equals method should check if the other object is the same instance as the first step
lhotari
requested review from
merlimat,
Technoboy-,
nodece,
dao-jun and
shibd
pdolif
approved these changes
Jan 19, 2025
nodece
approved these changes
Jan 20, 2025
BewareMyPower
approved these changes
Jan 20, 2025
Shawyeok
approved these changes
Jan 20, 2025
lhotari
added a commit
that referenced
this pull request
Jan 20, 2025
(cherry picked from commit 3c2ec2b)
lhotari
added a commit
that referenced
this pull request
Jan 20, 2025
(cherry picked from commit 3c2ec2b)
lhotari
added a commit
that referenced
this pull request
Jan 20, 2025
(cherry picked from commit 3c2ec2b)
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previously the equals method performance has been improved by @Shawyeok in PR [improve][broker] Make Consumer#equals more effective #18662. That addressed the main performance issue and this current PR is a small adjustment to avoid unnecessary work when there's a matching instance.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete