Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme.md #270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update readme.md #270

wants to merge 1 commit into from

Conversation

jacstrong
Copy link

@jacstrong jacstrong commented Jan 29, 2018

Added missing spaces to headers in the "Other useful commands" section. Before appeared as #####section now appears as

section
(markdown equivalent)

Description

What Changed?
readme.md was edited. There were missing spaces between the "#"s and the section title. The spaces were added.

Tests

Coverage?

[Description of what tests were written]

Links

Jira

Checklist

  • Code Review
  • Squash Commits

People To Reivew

[Add those who should review this]

Added missing spaces to headers in the "Other useful commands" section.  Before appeared as #####section now appears as <h5>section</h5>
@asfgit
Copy link

asfgit commented Jan 29, 2018

Can one of the admins verify this patch?

@jdasch
Copy link
Contributor

jdasch commented Feb 2, 2018

asfbot build

@asfgit
Copy link

asfgit commented Feb 2, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/684/

@pujav65
Copy link
Contributor

pujav65 commented Mar 9, 2018

hey @jacstrong I was going to pull this in, but I can't find a branch to pull it in off of. What am I missing here? I can find change on your master branch, but there is a check in after that that I cannot/do not want to pull in (the "this is stupid" one. Can you update the pull request to point to an existing branch on your repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants