Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency updates for vagrant example #318

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Conversation

DLotts
Copy link

@DLotts DLotts commented Oct 20, 2020

Vagrantfile changed to update Linux version, tomcat version, rdf4j server version.
This replaces #309 unless furkanozbay wants to pull and test from his original PR 309.
Updated tomcat (v9) , Accumulo v1.6.6 , RDF4J v2.5.5 and Ubuntu-18.04.
Fixed bugs with logging. Tomcat9 requires permissions for writable directories.

Tests

Go to vagrantExample and run vagrant up. No need to build Rya. However you do, you can easily use your own Rya build not from the repository.

See that it succeeds to build
You can run the thru the verification from the Readme.

People To Reivew

@adinancr @amihalik @furkanozbay

Copy link
Contributor

@adinancr adinancr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to run the vagrant file by changing the RYA_EXAMPLE_VERSION to 4.0.0-incubating. Everything worked fine.
It would be great if we could update the Accumulo version to 1.10.0 (their LTM release)

extras/vagrantExample/src/main/vagrant/Vagrantfile Outdated Show resolved Hide resolved
@@ -46,57 +47,37 @@ Vagrant.configure(2) do |config|
config.vm.hostname = "rya-example-box"

config.vm.provision "shell", inline: <<-SHELL

###set -x ## turn on command echo with expanded variables
# List of dependency versions
export ACCUMULO_VERSION=1.6.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance of updating the Accumulo dependency? 1.6.5 is very old

extras/vagrantExample/src/main/vagrant/Vagrantfile Outdated Show resolved Hide resolved
extras/vagrantExample/src/main/vagrant/Vagrantfile Outdated Show resolved Hide resolved
extras/vagrantExample/src/main/vagrant/Vagrantfile Outdated Show resolved Hide resolved
extras/vagrantExample/src/main/vagrant/readme.md Outdated Show resolved Hide resolved
extras/vagrantExample/src/main/vagrant/readme.md Outdated Show resolved Hide resolved
extras/vagrantExample/src/main/vagrant/readme.md Outdated Show resolved Hide resolved
extras/vagrantExample/src/main/vagrant/readme.md Outdated Show resolved Hide resolved
@k-tipp
Copy link

k-tipp commented Nov 19, 2020

I could also run the vagrant file without error changing RYA_EXAMPLE_VERSION to 4.0.0-incubating. However, the rdf4j-workbench seems to have problems. For example visiting http://rya-example-box:8080/rdf4j-workbench/repositories/[repository_name]/namespaces throws "java.lang.NoClassDefFoundError: Could not initialize class org.apache.accumulo.core.client.ZooKeeperInstance".

@DLotts
Copy link
Author

DLotts commented Dec 9, 2020 via email

@asfgit asfgit closed this in 718589a Dec 10, 2020
@asfgit asfgit merged commit 718589a into apache:master Dec 10, 2020
@k-tipp
Copy link

k-tipp commented Dec 11, 2020

Thanks for the update David. The problem still persists for me, maybe I have time in the next few days to investigate a little on it.

@DLotts
Copy link
Author

DLotts commented Dec 11, 2020 via email

@adinancr
Copy link
Contributor

I tested with Rya version 4.0.0-incubating and got the same error when trying to use workbench, but I was able to load data using the REST endpoint and query using http://rya-example-box:8080/web.rya/sparqlQuery.jsp

@DLotts
Copy link
Author

DLotts commented Dec 13, 2020 via email

@adinancr
Copy link
Contributor

I'm fine with the release and submitting a bug report, but we need to remove all incubating references before doing the release - see https://issues.apache.org/jira/browse/RYA-526
This was assigned to me, I just did not get to it. I can work on it tonight.

Also maybe the readme.md for the Vagrant file should change to reflect the latest versions used in the file (in particular the Common Errors in the VM section to replace tomcat with tomcat9 and make the versions of accumulo and zookeeper match with what is in the file)

@DLotts
Copy link
Author

DLotts commented Dec 14, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants