Bump up actions/upload-artifact and actions/download-artifact to v4 #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
previously approved these changes
Sep 18, 2024
mrproliu
previously approved these changes
Sep 18, 2024
CodePrometheus
dismissed stale reviews from mrproliu and wu-sheng
via
b858743
|
@mrproliu From the recent CI test, not only artifact@v2 is unavailable test1, but also colima, which macOS-ci depends on, cannot be started test2, since timeout the action are automatically canceled. I try to increase the corresponding startup parameters to solve the problem, but still find errors during compilation test3, so I want to temporarily shutdown macOS-ci, and then I will try to locate the problem or find a more stable solution. |
|
Make sense to me. |
|
Then please rollback all MacOS-related commits and only disable the MacOS test is enough. |
mrproliu
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the recent actions CI (such as CI-1) find that v2 does not work, so upgrade to v4 to solve this problem.