Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up BanyanDB Helm version to 0.3.0 #158

Merged
merged 4 commits into from
Sep 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/e2e.ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ jobs:
config: test/e2e/swck/oap-ui-agent-satellite.yaml
name: ${{ matrix.test.name }}
env:
OAP_TAG: 14c5778f57cc163b5a7d732555182b14dcff146b
OAP_TAG: ddbed6d091c4c20dbb43294fbd03778bdbb8471a
OAP_REPO: ghcr.io/apache/skywalking/oap
UI_TAG: 14c5778f57cc163b5a7d732555182b14dcff146b
UI_TAG: ddbed6d091c4c20dbb43294fbd03778bdbb8471a
UI_REPO: ghcr.io/apache/skywalking/ui
SATELLITE_TAG: v35bfaff6352b4dc351a706772796a1f79b651c14
SATELLITE_REPO: ghcr.io/apache/skywalking-satellite/skywalking-satellite
Expand Down Expand Up @@ -83,7 +83,7 @@ jobs:
du -sh $dir
done
docker images
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: ${{ failure() }}
name: Upload Logs
with:
Expand Down
5 changes: 5 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ Changes by Version
==================
Release Notes.

4.7.0
------------------

- Bump up Banyandb Helm version to 0.3.0.

4.6.0
------------------

Expand Down
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,13 @@ helm install "${SKYWALKING_RELEASE_NAME}" \
--set ui.image.tag=10.0.1 \
--set elasticsearch.enabled=false \
--set banyandb.enabled=true \
--set banyandb.image.tag=0.6.1
--set banyandb.image.tag=0.7.0
```

BanyanDB can be configured through various parameters. A comprehensive list of these parameters can be found in the configuration section of [BanyanDB Helm](https://github.com/apache/skywalking-banyandb-helm?tab=readme-ov-file#configuration) repository. These parameters allow you to customize aspects such as replication, resource allocation, persistence, and more to suit your specific deployment needs. Remember to prepend 'banyandb.' to all parameter names when applying the settings. For example, `banyandb.image.tag` can be used to specify the version of BanyanDB.

The _BanyanDB(>=0.7.0)_ is not compatible with the _BanyanDB Helm Chart(<0.3.0)_ which is referred by the _SkyWalking Helm Chart(<4.7.0)_. If you want to use _BanyanDB(>=0.7.0)_ as storage solution, you have to use the _BanyanDB Helm Chart(>=0.3.0)_ or _SkyWalking Helm Chart(>=4.7.0)_.

## Install released version using Apache Jfrog Helm repository (<= 4.3.0)

```shell
Expand Down
2 changes: 1 addition & 1 deletion chart/skywalking/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@ dependencies:
condition: postgresql.enabled
- name: skywalking-banyandb-helm
alias: banyandb
version: 0.2.0
version: 0.3.0-rc0
repository: oci://registry-1.docker.io/apache
condition: banyandb.enabled
62 changes: 57 additions & 5 deletions chart/skywalking/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,14 @@ Create the name of the service account to use for the satellite cluster
sleep 3
done
{{- else if eq .Values.oap.storageType "banyandb" -}}
{{- $banyandbHost := "banyandb-http" -}}
{{- if not .Values.banyandb.enabled -}}
{{- $banyandbHost = .Values.banyandb.config.httpHost -}}
{{- $address := .Values.banyandb.config.httpAddress -}}
{{- if .Values.banyandb.enabled -}}
{{- $address = printf "%s-http:%s" (include "skywalking.banyandb.fullname" .) (include "skywalking.banyandb.httpPort" .) -}}
{{- end }}
- name: wait-for-banyandb
image: curlimages/curl
imagePullPolicy: IfNotPresent
command: ['sh', '-c', 'for i in $(seq 1 60); do curl {{ $banyandbHost }}:{{ .Values.banyandb.config.httpPort }}/api/healthz && exit 0 || sleep 5; done; exit 1']
command: ['sh', '-c', 'for i in $(seq 1 60); do curl -k {{ $address }}/api/healthz && exit 0 || sleep 5; done; exit 1']
{{- end }}
{{- end -}}

Expand Down Expand Up @@ -160,7 +160,59 @@ Create the name of the service account to use for the satellite cluster
- name: SW_DATA_SOURCE_PASSWORD
value: "{{ .Values.postgresql.auth.password }}"
{{- else if eq .Values.oap.storageType "banyandb" }}
{{- $targets := .Values.banyandb.config.grpcAddress -}}
{{- if .Values.banyandb.enabled -}}
{{- $targets = printf "%s-grpc:%s" (include "skywalking.banyandb.fullname" .) (include "skywalking.banyandb.grpcPort" .) -}}
{{- end }}
- name: SW_STORAGE_BANYANDB_TARGETS
value: "{{ .Values.banyandb.config.targets }}"
value: "{{ $targets }}"
{{- end }}
{{- end -}}

{{/*
Expand the name of the banyandb chart.
*/}}
{{- define "skywalking.banyandb.name" -}}
{{- default "skywalking-banyandb-helm" .Values.banyandb.nameOverride | trunc 63 | trimSuffix "-" -}}
{{- end -}}


{{/*
Create a default fully qualified app name.
We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec).
If release name contains chart name it will be used as a full name.
*/}}
{{- define "skywalking.banyandb.fullname" -}}
{{- if .Values.banyandb.fullnameOverride -}}
{{- .Values.banyandb.fullnameOverride | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- $name := (include "skywalking.banyandb.name" .) -}}
{{- if contains $name .Release.Name -}}
{{- .Release.Name | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}}
{{- end -}}
{{- end -}}
{{- end -}}

{{/*
Define the banyandb http port
*/}}
{{- define "skywalking.banyandb.httpPort" -}}
{{- if .Values.banyandb.standalone.enabled -}}
{{- .Values.banyandb.standalone.httpSvc.port -}}
{{- else if .Values.banyandb.cluster.enabled -}}
{{- .Values.banyandb.cluster.liaison.httpSvc.port -}}
{{- end -}}
{{- end -}}

{{/*
Define the banyandb grpc port
*/}}
{{- define "skywalking.banyandb.grpcPort" -}}
{{- if .Values.banyandb.standalone.enabled -}}
{{- .Values.banyandb.standalone.grpcSvc.port -}}
{{- else if .Values.banyandb.cluster.enabled -}}
{{- .Values.banyandb.cluster.liaison.grpcSvc.port -}}
{{- end -}}
{{- end -}}
Loading
Loading