Fix TestReplicationHandler

[HoustonPutman]

This actually stems from two commits on the same day, kind of eerie.

SOLR-17306

This uncommented out:

System.setProperty("solr.directoryFactory", "solr.StandardDirectoryFactory");

Apparently when using the StandardDirectoryFactory, we see core snapshot directories when we don't see them using the default DirectoryFactory. The code already accounted for snapshot metadata, but not snapshots themselves. I updated the check to ignore any snapshot directory when counting index directories. @dsmiley, you wrote the snapshot metadata filtering, so can you check this for me?

SOLR-17548

In ReplicationTestHelper, this changed

FileUtils.copyFile(
        new File(SolrTestCaseJ4.TEST_HOME(), "solr.xml"),
        new File(instance.getHomeDir(), "solr.xml"));

to

Files.copy(
        Path.of(SolrTestCaseJ4.TEST_HOME(), "solr.xml"),
        Path.of(instance.getHomeDir(), "solr.xml"));

However, this forgot to allow for overwrites, as was done in other cases in this PR. Probably because nightly tests are usually forgotten.

[epugh]

@mlbiscoc I should have reminded/and or run the nightly tests when I was reviewing the path stuff.. Let's remember to do that as we continue!

[epugh]

Thanks @HoustonPutman for looking at these, and sorry I didn't catch them, as I think I reviewed both of those PR's. Is there some more unit testing that we need that would have prevented these regressions?

[epugh]

this seems so "magical" that you have to know about a "snapshot".

[HoustonPutman]

agreed, it's just in the error output that the snapshot is there. I know no magic 😅

[epugh]

LGTM

[HoustonPutman]

Thanks @HoustonPutman for looking at these, and sorry I didn't catch them, as I think I reviewed both of those PR's. Is there some more unit testing that we need that would have prevented these regressions?

We should have another crave job that runs the nightly tests. I looked into it, but I don't know where our crave config lives, so I don't know how to enable that.

[dsmiley]

I raised the topic on the dev list but FYI I'm our resident Crave expert.

[HoustonPutman]

@dsmiley do you have any opinion on adding the snapshot directories to the filter?

[dsmiley]

I don't recall. I used git blame and see that I was reviewing the contribution of a contributor "Hrishikesh Gadre" in SOLR-9269. Back then we used subversion; no contributor metadata in the commit message.

Change seems fine I guess. Basically you loosened from equals to startsWith.

[mlbiscoc]

@mlbiscoc I should have reminded/and or run the nightly tests when I was reviewing the path stuff.. Let's remember to do that as we continue!

Got it. Thanks @HoustonPutman for fixing the regression!