-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add TDengine.py driver to db_engine #32041
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
Category | Issue | Fix Detected |
---|---|---|
Insecure Credential Example in URI Placeholder ▹ view | ✅ |
Need a new review? Comment
/korbit-review
on this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-review
command in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-description
command in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolve
command in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Feedback and Support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DuanKuanJun thanks for opening this PR. Can you fill out the description for this PR? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #32041 +/- ##
===========================================
+ Coverage 0 83.33% +83.33%
===========================================
Files 0 546 +546
Lines 0 39051 +39051
===========================================
+ Hits 0 32543 +32543
- Misses 0 6508 +6508
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
already fill out the description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check how to correctly define the dependencies. Also, tests seem to be failing, please check CI logs.
|
Running CI now 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few additional comments. CI is still failing, please check the logs for what the issues are.
Co-authored-by: Ville Brofeldt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There's still CI issues, please check those. You may benefit from installing pre-commit hooks. Please check https://superset.apache.org/docs/contributing/development#git-hooks, as these automatically correct any code formatting issues for you.
feat: SuperSet support TDengine data source
SUMMARY
Through db_engine_spec for TDengine, Superset can support TDengine data sources and provide functions such as data presentation and analysis, see detail.
TESTING INSTRUCTIONS
format: taosws://user:password@host:port
ADDITIONAL INFORMATION