Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add ability to import also secure/encrypted extra for databases #32134

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drummerwolli
Copy link
Contributor

SUMMARY

This PR extends the import functionality to handle encrypted_extras (shown as "Secure Extra" in the UI) for databases. Key changes include:

  1. Added encrypted_extras parameter to ImportModelsCommand and ImportAssetsCommand.
  2. Updated load_configs function to populate encrypted_extra from the request or existing databases.
  3. Modified the API schema to include encrypted_extras in the request body.
  4. Updated ImportExportRestApi to parse and pass encrypted_extras to the import command.

This change allows users to provide encrypted_extras when importing databases, improving the flexibility and security of the import process.

The encrypted extras work similiarly to passwords, you need to provide them in an extra form in the API request.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

n/a

TESTING INSTRUCTIONS

  1. deploy superset
  2. import a database with an encryped extra

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Feb 4, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@github-actions github-actions bot added the api Related to the REST API label Feb 4, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset/commands/importers/v1/init.py
superset/commands/importers/v1/assets.py
superset/importexport/api.py
superset/commands/importers/v1/utils.py

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Documentation
Logging
Error Handling
Readability and Maintainability
Design Patterns
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

@sadpandajoe sadpandajoe added review:checkpoint Last PR reviewed during the daily review standup review:draft labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the REST API review:checkpoint Last PR reviewed during the daily review standup review:draft size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants