fix(releasing): fix borked SVN-based image building process #32151
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
…ss to v20 Signed-off-by: hainenber <[email protected]>
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Documentation ✅ Logging ✅ Error Handling ✅ Readability and Maintainability ✅ Design Patterns ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
hainenber
commented
Feb 5, 2025
| @@ -35,7 +35,7 @@ RUN apt-get install -y build-essential libssl-dev \ | |||
| # Install nodejs for custom build | |||
| # https://nodejs.org/en/download/package-manager/ | |||
| RUN set -eux; \ | |||
| curl -sL https://deb.nodesource.com/setup_18.x | bash -; \ | |||
There was a problem hiding this comment.
This is in line with Node version noted in .nvmrc
hainenber
commented
Feb 5, 2025
|
|
||
| # Install nodejs for custom build | ||
| # https://nodejs.org/en/download/package-manager/ | ||
| RUN curl -sL https://deb.nodesource.com/setup_16.x | bash - \ | ||
| && apt-get install -y nodejs | ||
| RUN set -eux; \ |
There was a problem hiding this comment.
This is to reduce diffs from Dockerfile.from_local_tarball and reduce less mental burden for future reviewer when it comes to diffing these 2 Dockerfiles
michael-s-molina
approved these changes
Feb 5, 2025
michael-s-molina
added
the
v5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: add missing zstd dependency for SVN-based tarball Dockerfile
SUMMARY
Sort of extension for @michael-s-molina's #32135 and a full fix for
Dockerfile.from_svn_tarballBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION