-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update setting up and running in cloud #936
Conversation
vdusek
commented
Jan 24, 2025
- I updated the "Setting up" and "Running in cloud" pages to make them more beginner-friendly (hopefully) and also removed mentions of Poetry. Including Poetry was unnecessary and could be confusing. Not to mention in Python there are X other package managers that we could hypotetically mention as well. So I decided to stay only with Pip and Pipx for templates. People using a package manager other than Pip will likely know how to handle the installation on their own.
- This was reported on Slack by @honzajavorek.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 I'd like to see the comment about apify init
addressed, as that's my current roadblock when working on the Python course.
🔴 I don't know if you aim to support Windows, but if so, these documents need more love and verification that all works there as intended. AFAIK the venv creation and activation won't work for sure.
🟡 Otherwise I didn't find anything serious, just various unimportant nitpicks about lower/uppercase letters (I'm sorry!) and I offered several improvements to the flow of the text. I dig removing poetry from the mix.
eae0214
to
bc163cf
Compare
Thanks @honzajavorek for your review.
I'm not sure how much detail we should provide about the Apify CLI and
@Pijukatel If it's not a problem, could you please address this? It is this comment. |
@vdusek That's a good point that while addressing the |