Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Do not wait for code checks on release if the head commit skips CI #948

Merged
merged 1 commit into from
Jan 31, 2025
Merged

ci: Do not wait for code checks on release if the head commit skips CI #948

merged 1 commit into from
Jan 31, 2025

Conversation

janbuchar
Copy link
Collaborator

No description provided.

@janbuchar janbuchar added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Jan 31, 2025
@github-actions github-actions bot added this to the 107th sprint - Tooling team milestone Jan 31, 2025
vdusek
vdusek approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

B4nan
B4nan approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but my brain is not good at processing bash commands on its own so I hope you've tested this 🙃

@janbuchar
Copy link
Collaborator Author

looks good, but my brain is not good at processing bash commands on its own so I hope you've tested this 🙃

It's the same fix that we applied to the CLI, so it should be... fine

@janbuchar janbuchar merged commit 3dffdca into master Jan 31, 2025
23 checks passed
@janbuchar janbuchar deleted the fix-wait-for-checks branch January 31, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

@B4nan B4nan B4nan approved these changes

@Pijukatel Pijukatel Awaiting requested review from Pijukatel

Assignees

@janbuchar janbuchar

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
107th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
3 participants
@janbuchar @B4nan @vdusek