-
Notifications
You must be signed in to change notification settings - Fork 62
Conversation
concept ACK. But looks like certain feature combos are broken (see CI) |
235f416
to
55f40cb
Compare
I thought after the first approval the other times the CI would start automatically, but it's not the case, I hope to have "blindly" fixed it. |
55f40cb
to
2c3f462
Compare
I think to have tested all the cases launched with the CI locally, sorry for the back and forth |
All good. I blame Github, not you :). Hit CI. Let's see how it goes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 2c3f462
@RCasatta can you add a unit test that demonstrates how to provide a list, and maybe a CHANGELOG entry explaining this? This will be a breaking change which will be particularly annoying because the |
according to the jsonrpc spec params can be missing, or an object too
c8986b8
to
178ee93
Compare
I had to force push because there were a couple of reference of Moreover, I added:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 178ee93
@@ -1,3 +1,8 @@ | |||
# 0.17.0 - 2023-06-29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Perhaps use "unreleased" so we don't forget to update the header when doing the release.
# 0.17.0 - 2023-06-29 | |
# unreleased |
Looks like some clippy lints are causing CI to fail. |
178ee93
to
be69ad1
Compare
Sorry again, should be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK be69ad1
Previously you had to provide a list with each thing wrapped in I think we need a better API here. |
You don't need the |
@RCasatta ah, I gotcha. So in your Ok, I'm happy then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 2c3f462
according to the jsonrpc spec params can be missing, or an object too.
close #107
Breaking change