This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
WIP: refactor to support sync/async support #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenroose
force-pushed
the
request
branch
4 times, most recently
from
95b6227 to
b8624d7
Compare
dpc
reviewed
Apr 5, 2023
| @@ -30,10 +30,16 @@ simple_uds = [] | |||
| # Enable Socks5 Proxy in transport | |||
| proxy = ["socks"] | |||
|
|
|||
| # transport implementations | |||
| tp-hyper = [ "hyper" ] | |||
Merged
|
Relevant comment by @apoelstra about async in this crate (so I can find it later: rust-bitcoin/rust-miniscript#662 (comment)) |
|
Once #117 through #121 are in I'm going to pick this up and try and rebase it, do you know of any landmines I should know about @apoelstra or @stevenroose? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP but I publish it because it is used in a WIP refactor for the bitcoincore-rpc crate which uses this