Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set the license URL in the POMs #6247

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Do not set the license URL in the POMs #6247

merged 1 commit into from
Nov 12, 2024

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Nov 7, 2024

Fix for #6240

See also cashapp/licensee#137

@BoD BoD requested a review from martinbonnin as a code owner November 7, 2024 14:24
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Nov 7, 2024

✅ Docs Preview Ready

No new or changed pages found.

@martinbonnin
Copy link
Contributor

For the record, checked with different tools, users need to update their configuration:

cashapp/licensee

licensee {
  // Replace
  allowUrl("https://raw.githubusercontent.com/apollographql/apollo-kotlin/main/LICENSE")
  
  // With
  allow("MIT")
}

jk1/Gradle-License-Report

{
    "allowedLicenses": [
        {
            <!-- Replace -->
            "moduleLicense": "MIT License",
            <!-- With -->
            "moduleLicense": "MIT"
        }
    ]
}

With jk1/Gradle-License-Report, the report does not display the url anymore (which is somewhat expected):

Before:
Screenshot 2024-11-08 at 14 44 35

After:
Screenshot 2024-11-08 at 14 45 06

@martinbonnin
Copy link
Contributor

I still think it makes sense. Let's give it the weekend until we merge this?

@BoD BoD merged commit e5c9bf8 into main Nov 12, 2024
6 checks passed
@BoD BoD deleted the no-url-in-pom-license branch November 12, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants