-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ jira-permissions-validator: sharding support #4813
✨ jira-permissions-validator: sharding support #4813
Conversation
c4541c4
to
f30d0c2
Compare
The code looks fine, what I don't get is the concept. How sharding by board is going to help us? I'm mainly afraid of how costly is this in resources (we have 50 boards, hence 50 processes running). Have we tried something a bit less costly as static sharding. Apologies if this has been answered elsewhere... |
If the integration hits the rate limit, then just one board is affected. Any retry won't start from the beginning and needs fewer API requests.
TBH, I don't understand the static sharing concept. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chassing and I discussed about this in a call. Since we're in bad position with JIRA guys, let's try this (which may be a bit overkill) and in the future maybe look for other solutions like:
- only run PR checks in affected boards
- introduce a random wait per board in the integration and remove per board sharding
For the moment, let's try the overkill solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
e628a07
to
64fd429
Compare
Add sharding support to the
jira-permissions-validator
integration to reduce amount of Jira API calls.Depends on: app-sre/qontract-schemas#757
Ticket: APPSRE-11408