Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bound_service_account_namespace_selector to k8s role for vault #762

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions graphql-schemas/schema.yml
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,7 @@ confs:
- { name: audience, type: string }
- { name: bound_service_account_names, type: string, isList: true, isRequired: true }
- { name: bound_service_account_namespaces, type: string, isList: true, isRequired: true }
- { name: bound_service_account_namespace_selector, type: string, isRequired: true }
- { name: token_ttl, type: string, isRequired: true }
- { name: token_max_ttl, type: string, isRequired: true }
- { name: token_explicit_max_ttl, type: string, isRequired: true }
Expand Down
3 changes: 3 additions & 0 deletions schemas/vault-config/role-1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,8 @@ properties:
type: array
items:
type: string
bound_service_account_namespace_selector:
type: string
Copy link
Contributor

@patjlm patjlm Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't that be a LabelSelector object content instead of a string?

token_ttl:
type: string
pattern: '^\d+$'
Expand Down Expand Up @@ -249,6 +251,7 @@ properties:
- alias_name_source
- bound_service_account_names
- bound_service_account_namespaces
- bound_service_account_namespace_selector
- token_ttl
- token_max_ttl
- token_explicit_max_ttl
Expand Down