-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO-NOT-MERGE] PR encompassing all changes needed to support neuron on Axlearn #919
Open
apoorvtintin
wants to merge
34
commits into
apple:main
Choose a base branch
from
apoorvtintin:mainline_upstream_do_not_merge
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[DO-NOT-MERGE] PR encompassing all changes needed to support neuron on Axlearn #919
apoorvtintin
wants to merge
34
commits into
apple:main
from
apoorvtintin:mainline_upstream_do_not_merge
+707
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix neuron attention to make unit tests run * remove top level iport from flash attention utils * revert LNC change
* fix regressions and messages * tpu_health_check.py import * not defined variables * full name for neuron
Merge fix for heads % 2 != 0
* added back skipping to test_pipeline_summary_writer * fix host_array tests
apoorvtintin
requested review from
ruomingp,
markblee and
a team
as code owners
January 13, 2025 18:24
ruomingp
reviewed
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all of the changes needed to run fuji family of models on TRN2/1. This PR is actively being broken down to create smaller and manageable PRs that can be reviewed/merged to Axlearn.
Smaller PRs created
This PR replaces the previous do-not-merge PR from a different fork. Sorry for the last minute change