Enable GCP Workload Monitoring #932
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markblee
reviewed
Jan 28, 2025
| @@ -219,6 +221,26 @@ def __init__( | |||
| super().__init__(cfg, parent=parent) | |||
| cfg = self.config | |||
|
|
|||
| self.gcp_workload_monitor = None | |||
There was a problem hiding this comment.
The trainer shouldn't have any dependencies on GCP specific logic. BTW, I wonder whether the monitoring events can be inferred from the events recorded by the measurement utils -- what are the main differences?
There was a problem hiding this comment.
Got it! I will decouple the GCP logic from Trainer. I am thinking to do the following
- Create a
GCPRecorderclass that inherits fromRecorder. - Register the
GCPRecorderwith the decorator@register_recorder. - Finally, in
Trainerif GCP monitoring is enabled, I will initializemeasurementwith therecorder_typeset togcp:gcpto use GCPRecorder.
Hopefully this will enable GCP monitoring in a cleaner way!
Let me know if it make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate Workload Observability to AXLearn Framework